Add chart upgrade test#2731
Open
khushboo-rancher wants to merge 1 commit into
Open
Conversation
Signed-off-by: Khushboo <fnu.khushboo@suse.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Rancher integration coverage for upgrading Harvester CSI and cloud provider charts (n-1 → latest) on imported RKE2 clusters, including new Rancher library capabilities to perform chart upgrades/uninstalls and to validate chart repo/app state during those operations.
Changes:
- Add Robot upgrade test cases for CSI + cloud provider charts on imported RKE2 clusters, plus supporting upgrade/restart/cleanup keywords.
- Extend Rancher client layers (REST/CRD + wrappers) with deployment scaling, chart upgrade/uninstall, and “wait with expected version/branch” verification.
- Introduce optional
CSI_CHART_VERSION/CP_CHART_VERSIONvariables to pin chart versions for install/upgrade scenarios.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| harvester_robot_tests/tests/regression/test_rancher_integration.robot | Adds CSI/cloud provider chart upgrade test cases and updates tags/setup steps. |
| harvester_robot_tests/libs/rancher/rest.py | Implements REST-side deployment scaling, chart upgrade/uninstall, chart deletion wait, and adds optional branch/version verification in waiters. |
| harvester_robot_tests/libs/rancher/crd.py | Implements CRD/kubectl-side deployment scaling, chart upgrade/uninstall, chart deletion wait, and adds optional branch/version verification in waiters. |
| harvester_robot_tests/libs/rancher/rancher.py | Exposes new Rancher operations through the delegating wrapper (REST/CRD). |
| harvester_robot_tests/libs/rancher/base.py | Extends the abstract Rancher interface with the new operations and waiter parameters. |
| harvester_robot_tests/libs/keywords/rancher_keywords.py | Exposes new Rancher operations to Robot keywords, including “upgrade latest if version empty” behavior. |
| harvester_robot_tests/keywords/variables.resource | Adds CSI_CHART_VERSION and CP_CHART_VERSION variables for version pinning. |
| harvester_robot_tests/keywords/rancher.resource | Adds Robot keywords for upgrade/uninstall/scale, upgrade test flows, and expected branch/version verification wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue # #2721
What this PR does / why we need it:
This PR adds test to verify the upgrade of chart from n-1 to latest.
Added CSI_CHART_VERSION & CP_CHART_VERSION which enable us to test specific version of chart.
Special notes for your reviewer:
Additional documentation or context