Render exercise text via textContent, not innerHTML - #61
Open
thejesh23 wants to merge 1 commit into
Open
Conversation
Instruction steps, meta chip values, and active filter badges built their DOM with template-string innerHTML, so any exercise-derived string containing HTML would be parsed as markup. Build the nodes and set text via textContent instead. Closes hasaneyldrm#60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instruction steps, meta chip values, and active filter badges were built with template-string
innerHTML, so any exercise-derived string containing HTML (or an&/</>) would be parsed as markup — an injection surface today, a rendering bug even for benign inputs. Replaced each withtextContent-based DOM construction (the same pattern already used forcard-name,muscle-tag, etc.).Closes #60