Open
Conversation
- Refactor HTSTransactionAdapter into composition-based ClientTransactionAdapter - Split operations into dedicated classes (TokenOperations, HoldOperations, RoleOperations, etc.) - Add auto-association token support - Fix transfer auto association - Update SDK tests and mocks - Pin web dependencies - Update contracts tests Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
⛔ Snyk checks have failed. 3 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request includes several improvements and refactorings across the Docker configuration, smart contracts, and test files. The main goals are to improve Docker build efficiency, clean up and standardize Solidity and TypeScript code, update dependencies, and enhance code readability in tests.
Docker and Development Environment Improvements:
backend/Dockerfileto separate copying of root files and backend source, set the working directory explicitly, and optimize dependency installation for both development and production builds. These changes streamline the Docker image build process and improve clarity. [1] [2] [3]backend/compose.yamlto use the correct context, Dockerfile path, working directory, and volumes, ensuring the backend service runs in the intended environment. Also updated thecommandto invoke the Nest CLI directly from the installed dependencies. [1] [2]Smart Contract Refactoring and Cleanup:
BurnableFacet.sol,SupplierAdminFacet.sol,TokenOwnerStorageWrapper.sol,PrecompiledMock.sol). [1] [2] [3] [4] [5] [6] [7]Dependency and Configuration Updates:
hardhatandprettier-plugin-solidityto newer versions incontracts/package.jsonto keep the development environment up to date.Test Code Improvements:
These changes collectively improve the project's maintainability, developer experience, and code quality.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist