Skip to content

feat: Implementation of HWC 2.0#1396

Open
jaime-iobermudez wants to merge 5 commits intodevelopfrom
feat/hwc-203-appkit-v2
Open

feat: Implementation of HWC 2.0#1396
jaime-iobermudez wants to merge 5 commits intodevelopfrom
feat/hwc-203-appkit-v2

Conversation

@jaime-iobermudez
Copy link
Contributor

Description:

This pull request includes several improvements and refactorings across the Docker configuration, smart contracts, and test files. The main goals are to improve Docker build efficiency, clean up and standardize Solidity and TypeScript code, update dependencies, and enhance code readability in tests.

Docker and Development Environment Improvements:

  • Refactored the backend/Dockerfile to separate copying of root files and backend source, set the working directory explicitly, and optimize dependency installation for both development and production builds. These changes streamline the Docker image build process and improve clarity. [1] [2] [3]
  • Updated the backend/compose.yaml to use the correct context, Dockerfile path, working directory, and volumes, ensuring the backend service runs in the intended environment. Also updated the command to invoke the Nest CLI directly from the installed dependencies. [1] [2]

Smart Contract Refactoring and Cleanup:

  • Refactored several Solidity contract methods to use single-line function signatures, improving code readability and consistency (BurnableFacet.sol, SupplierAdminFacet.sol, TokenOwnerStorageWrapper.sol, PrecompiledMock.sol). [1] [2] [3] [4] [5] [6] [7]
  • Standardized string literals to use single quotes instead of double quotes in Solidity and TypeScript files for consistency. [1] [2] [3] [4]

Dependency and Configuration Updates:

  • Updated hardhat and prettier-plugin-solidity to newer versions in contracts/package.json to keep the development environment up to date.
  • Minor formatting improvements in TypeScript configuration files to enhance clarity.

Test Code Improvements:

  • Improved formatting and consistency in test files, including better alignment, destructuring, and argument formatting. This enhances readability and maintainability of the test suite. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

These changes collectively improve the project's maintainability, developer experience, and code quality.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

- Refactor HTSTransactionAdapter into composition-based ClientTransactionAdapter
- Split operations into dedicated classes (TokenOperations, HoldOperations, RoleOperations, etc.)
- Add auto-association token support
- Fix transfer auto association
- Update SDK tests and mocks
- Pin web dependencies
- Update contracts tests

Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
@swirlds-automation
Copy link

swirlds-automation commented Feb 17, 2026

Snyk checks have failed. 3 issues have been found so far.

Status Scanner Critical High Medium Low Total (3)
Open Source Security 0 3 0 0 3 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
@sonarqubecloud
Copy link

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants