Add context cancellation support and export special path constants fo…#140
Open
peteski22 wants to merge 1 commit into
Open
Add context cancellation support and export special path constants fo…#140peteski22 wants to merge 1 commit into
peteski22 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add context cancellation support and export FileSink-specific path constants to improve integration capabilities and enable graceful shutdown handling.
Changes
Context Support:
FileSink.Process()at two strategic points: before processing and after acquiring the mutex lockExported Constants:
FileStdout,FileStderr, andFileDevNullwith proper Go documentationTesting:
Backward Compatibility
Process()method signature but unused. No existing functionality is modified.PCI review checklist
[x] I have documented a clear reason for, and description of, the change I am making.
[x] If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
[x] If applicable, I've documented the impact of any changes to security controls.
Reason: Enable proper context cancellation for
FileSinkoperations and provide standardized constants for special file paths. This improves integration with applications requiring graceful shutdown capabilities (like Vault) while maintaining existing security posture.Revert Plan: N/A - Changes are purely additive and backward compatible. Simple PR revert is sufficient.
Security Impact: No changes to security controls. The exported constants maintain the same file path restrictions, and context cancellation adds fail-safe behavior that prevents operations on cancelled contexts.