Skip to content

fix: skip default restart check when custom restart_check_command is provided #13654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AruneshDwivedi wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −5
Open

fix: skip default restart check when custom restart_check_command is provided #13654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46a5aad
fix: skip default restart check when custom restart_check_command is …
AruneshDwivedi Jun 5, 2026
de83922
Merge branch 'main' into fix/windows-restart-custom-check-command
AruneshDwivedi Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions provisioner/windows-restart/provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,7 @@ WaitLoop:
}

var waitForCommunicator = func(ctx context.Context, p *Provisioner) error {
runCustomRestartCheck := true
if p.config.RestartCheckCommand == DefaultRestartCheckCommand {
runCustomRestartCheck = false
}
runCustomRestartCheck := p.config.RestartCheckCommand != DefaultRestartCheckCommand
// This command is configurable by the user to make sure that the
// vm has met their necessary criteria for having restarted. If the
// user doesn't set a special restart command, we just run the
Expand All @@ -236,7 +233,9 @@ var waitForCommunicator = func(ctx context.Context, p *Provisioner) error {
continue
}
log.Printf("Connected to machine")
runCustomRestartCheck = false
// User provided a custom check — skip the default PowerShell
// module-load check to avoid breaking Constrained Language Mode.
break
}
// This is the non-user-configurable check that powershell
// modules have loaded.
Expand Down