Skip to content

command/meta: Enable migration from PSS to a backend #37949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
radeksimko wants to merge 3 commits into
base: main
Choose a base branch
from
Open

command/meta: Enable migration from PSS to a backend #37949

radeksimko wants to merge 3 commits into from
+361 −152

Conversation

@radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 28, 2025

Fixes #

Target Release

1.15.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@radeksimko radeksimko force-pushed the radek/pss-migrate-to-backend branch from 31808ef to a1c9209 Compare December 3, 2025 16:52
@radeksimko radeksimko added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Dec 3, 2025
@radeksimko radeksimko force-pushed the radek/pss-migrate-to-backend branch from a1c9209 to 5e08a2d Compare December 4, 2025 13:16
@radeksimko radeksimko marked this pull request as ready for review December 4, 2025 13:17
@radeksimko radeksimko requested a review from a team as a code owner December 4, 2025 13:17
@SarahFrench SarahFrench self-assigned this Dec 4, 2025
SarahFrench
SarahFrench requested changes Dec 4, 2025
View reviewed changes
Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of things that need addressing, including something I missed in a past PR review - sorry! 🙈

@radeksimko radeksimko force-pushed the radek/pss-migrate-to-backend branch from 72bcff4 to 3dc973f Compare December 8, 2025 11:37
@radeksimko radeksimko force-pushed the radek/pss-migrate-to-backend branch from 3dc973f to bb223c7 Compare December 8, 2025 14:45
SarahFrench
SarahFrench previously approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those last comments! I've left some nit comments below but I don't think they should block merging & can be addresses later if needed.

internal/command/meta_backend.go
Comment on lines +1886 to +1887
// Unconfiguring a state store (moving from state store => backend).
func (m *Meta) stateStore_c_S(ssSMgr *clistate.LocalState, dstBackendType string, dstBackend backend.Backend, newBackendState *workdir.BackendConfigState, viewType arguments.ViewType) (backend.Backend, tfdiags.Diagnostics) {
Copy link
Member

@SarahFrench SarahFrench Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The naming of this method (following conventions in backend-related methods) indicates that there is no config via the lower-case c and there is backend state via the upper-case S. This isn't true anymore- maybe it could be renamed to stateStore_toBackend or something similar instead?

Copy link
Member Author

@radeksimko radeksimko Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that is a fair point! I can rename it.

@radeksimko @SarahFrench
Update internal/command/meta_backend.go
ef90f3d 
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SarahFrench SarahFrench SarahFrench left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@SarahFrench SarahFrench

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radeksimko @SarahFrench