Conversation
Collaborator
Author
Collaborator
Author
|
@fendor frankly I'm not sure what's the best way to proceed:
|
Collaborator
|
To me, (1) sounds fine, as we do the same in HLS. At first, you won't be able to compile hiedb with ghc 9.14 from hackage, but that limitation is likely to be lifted by the next |
Collaborator
Author
|
FYI @wz1000 @fendor: algebraic-graphs has a new 9.14 compatible version on hackage, so I removed the no longer necessary source-repository-package from this PR and it's passing with all ghc versions in cluding 9.14 (see CI in my fork jhrcek#3) Feel free to review/leave comments, otherwise I'll just merge this and release a new hiedb version to hackage tomorrow. |
Collaborator
|
LGTM :) |
Collaborator
Author
|
Uploaded to hackage https://hackage.haskell.org/package/hiedb-0.8.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what to do about the algebraic-graphs dependency. For now just copy-pasting source-repository-package config from hls 9.14 PR: https://github.com/haskell/haskell-language-server/pull/4780/files#diff-b8ed06757045fac949c89f2139a862498ad2b6d1f82c61a31e7c91d6cf0eaa70R12