-
Notifications
You must be signed in to change notification settings - Fork 85
Add OPTIONS_HAPPY pragma for passing flags to happy #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgraf812
reviewed
Aug 10, 2025
Collaborator
sgraf812
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I agree it would be a nice feature to have. But I have a few smaller suggestions.
…rse` Otherwise we get a clash when users omit a `%name` declaration, because then the default name for the parser is `happyParse`.
Suggested-by: Sebastian Graf <sgraf1337@gmail.com>
Suggested-by: Sebastian Graf <sgraf1337@gmail.com>
3d906d7 to
0e38381
Compare
0e38381 to
b4df3e2
Compare
Collaborator
|
Thanks! I released 2.1.7 with this feature. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Aug 21, 2025
## 2.1.7
* Add support for `{-# OPTIONS_HAPPY ... #-}` pragmas
([#342](haskell/happy#342)).
* Tested with GHC 8.0 - 9.12.2.
The Haskell code generated by Happy is for GHC 8.0 and up.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Aug 21, 2025
## 2.1.7
* Add support for `{-# OPTIONS_HAPPY ... #-}` pragmas
([#342](haskell/happy#342)).
* Tested with GHC 8.0 - 9.12.2.
The Haskell code generated by Happy is for GHC 8.0 and up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is surprisingly difficult to get haskell build tools to pass options to
happy:cabalonly lets you do it viacabal.projectfiles or via--happy-options, and the--happy-optionflag instackis just flat-out broken. This PR tries to fix this by adding aOPTIONS_HAPPYpragma to thehappygrammar, which lets you specify options to pass to happy directly within the.yfile.