Skip to content

break(kernel): 💥 Improve kernel contracts and environment schema - #20

Merged
haskou merged 6 commits into
mainfrom
break/kernel-quality-improvements
Jun 29, 2026
Merged

break(kernel): 💥 Improve kernel contracts and environment schema#20
haskou merged 6 commits into
mainfrom
break/kernel-quality-improvements

Conversation

@haskou

@haskou haskou commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add typed environment schema choices with runtime validation and literal TypeScript inference.
  • Add environment schema metadata fields for documentation and operational tooling.
  • Move kernel consumer and route registration types to core contracts with KernelConsumer and KernelRoute.
  • Make adapter Consumer and Route implement/extend those kernel contracts.
  • Document adapter-specific install/import paths and the registration contracts.
  • Keep coverage focused on runtime kernel files instead of excluding all src/kernel.

Breaking changes

  • Kernel consumer registration is now typed against KernelConsumer instead of the pub/sub adapter Consumer base class.
  • Kernel route registration is now typed against KernelRoute instead of the UI adapter Route base class.
  • Custom registered consumers must expose queueName and init(). Adapter consumers already comply.
  • Custom registered routes should extend or be assignable to KernelRoute. Adapter routes already comply.

Validation

  • yarn typecheck
  • yarn lint
  • yarn build
  • yarn test:coverage
  • yarn docs:build
  • yarn format:check
  • yarn --cwd example typecheck

@codecov-commenter

codecov-commenter commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 900cc9c49c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/kernel/KernelEnvironmentVariableDefinition.ts Outdated
Comment thread src/kernel/KernelEnvironmentVariableDefinition.ts Outdated
@haskou
haskou force-pushed the break/kernel-quality-improvements branch from bf345ef to 62ba856 Compare June 29, 2026 11:00
@haskou

haskou commented Jun 29, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62ba856614

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/contracts/kernel/KernelRoute.ts Outdated
@haskou
haskou merged commit 1d724de into main Jun 29, 2026
2 checks passed
@haskou
haskou deleted the break/kernel-quality-improvements branch June 29, 2026 11:18
github-actions Bot added a commit that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants