Skip to content

fix(kernel): 🐛 Harden env and dependency injection runtime - #29

Merged
haskou merged 2 commits into
mainfrom
fix/env-autowire-compatibility
Jun 29, 2026
Merged

fix(kernel): 🐛 Harden env and dependency injection runtime#29
haskou merged 2 commits into
mainfrom
fix/env-autowire-compatibility

Conversation

@haskou

@haskou haskou commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Treat blank optional environment variables as absent, and use defaults for blank optional values with defaultValue.
  • Keep required blank environment variables failing with a specific validation error.
  • Improve environment validation errors for missing, blank and invalid parsed values.
  • Filter known non-actionable autowire warnings from type-only/default declaration files without hiding actionable warnings.
  • Cover overrides for external references generated from @haskou/ddd-kernel subpath imports.
  • Add runtime compatibility fixtures for ts-node and dist CommonJS using public subpaths, environmentSchema and dependencyInjection overrides.

Validation

  • yarn install --frozen-lockfile
  • yarn typecheck
  • yarn lint
  • yarn build
  • yarn test:coverage
  • yarn docs:build
  • yarn format:check
  • yarn --cwd example typecheck

@codecov-commenter

codecov-commenter commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02a275114c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/infrastructure/dependency-injection/AutowireWarningFilter.ts Outdated
@haskou
haskou merged commit 9cf548e into main Jun 29, 2026
2 checks passed
@haskou
haskou deleted the fix/env-autowire-compatibility branch June 29, 2026 20:23
github-actions Bot added a commit that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants