fix(express): 🐛 Resolve external controllers without DI noise - #35
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffbe20d85b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ffbe20d to
2f352dc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d0cbeb3 to
84c34e8
Compare
84c34e8 to
4fcafdf
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fcafdf294
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Summary
Add a controller-aware resolver for ExpressKernelServer routing-controllers integration.
Fallback to cached plain controller instances only when a known controller class itself is missing from kernel DI.
Keep non-controller missing services and dependency resolution failures visible.
Document external controller DI fallback behavior.
Validation
yarn typecheck
yarn lint
yarn test:coverage (100%)
yarn docs:build
yarn format:check
yarn --cwd example typecheck