Skip to content

break(metrics): 💥 Harden metrics public API - #4

Merged
haskou merged 4 commits into
mainfrom
break/metrics-api-hardening
Jul 15, 2026
Merged

break(metrics): 💥 Harden metrics public API#4
haskou merged 4 commits into
mainfrom
break/metrics-api-hardening

Conversation

@haskou

@haskou haskou commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • add global instrumentation defaults to configureMetrics
  • restrict the root package exports to the public entrypoints
  • expose advanced APIs through contracts and model subpaths
  • include structured error details in failure logs
  • document Prometheus cardinality rules

Impact

This is a breaking API hardening change because support/model exports are no longer re-exported from the package root.

Validation

  • yarn lint
  • yarn typecheck
  • yarn test:coverage
  • yarn docs:build
  • yarn test:package
  • yarn build

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46f798f34b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
Comment thread src/instrumentation/MetricsInstrumenter.ts Outdated
Base automatically changed from feat/real-playground to main July 15, 2026 22:43
@haskou
haskou merged commit db8b90f into main Jul 15, 2026
2 checks passed
@haskou
haskou deleted the break/metrics-api-hardening branch July 15, 2026 22:52
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

github-actions Bot added a commit that referenced this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant