63a87f71: BUG: attachments — 'domain configure' is metadata-only; does not aut

[andrei-hasna]

Automated task drain for 63a87f71.

Task: BUG: attachments — 'domain configure' is metadata-only; does not auto-wire Cloudflare (Worker/route/DNS), so custom domain never serves

Agent verdict: DONE
Clarified that domain configure saves metadata only, added deployment and verification guidance, and covered it with a CLI regression test.

Opened by the e2b-task-drain fleet (codex gpt-5.6-sol, effort xhigh).
Not auto-merged — review before landing.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

[andrei-hasna]

[REVIEW] NO_GO — #25 @ b3fb301 — lens: correctness+security+gates, reviewer Augustus (1 of 1)

Verdict: NO_GO only because the current PR head is not mergeable into current main. I found no blocking P0/P1 defect in the changed domain configure behavior itself.

What I ran with exit codes:

• git log --oneline origin/main..HEAD: 0
• git diff origin/main...HEAD --stat: 0
• Full per-file git diff origin/main...HEAD -- <file> for README.md, src/cli/commands/domain.ts, and src/cli/commands/domain.test.ts: 0
• bun install: 0
• bun run typecheck: 0
• bun test: 1. This is Bun's raw all-files runner; it fails in unchanged MCP/S3 mock-heavy tests because the repo test harness deliberately runs test files in isolated processes.
• bun run test: 0. This is the package-declared test gate, bash scripts/test.sh; it reported Checks: 54 total, 54 passed, 0 failed.
• bun test src/cli/commands/domain.test.ts: 0
• gh pr view 25 --repo hasna/attachments --json headRefOid,baseRefOid,mergeStateStatus,statusCheckRollup: 0. The head matched b3fb3017dd40acbf345167bd203c3000a8867cc1; GitHub reported mergeStateStatus: DIRTY.
• git merge-tree $(git merge-base HEAD origin/main) HEAD origin/main: 0, and the output reports a README.md conflict against current origin/main.

What I read:

• Full diffs for README.md, src/cli/commands/domain.ts, and src/cli/commands/domain.test.ts.
• Surrounding source in src/cli/commands/domain.ts, src/cli/commands/domain.test.ts, src/core/config.ts, src/core/deployment.ts, src/core/deployment.test.ts, src/cli/index.ts, package.json, scripts/test.sh, hasna.contract.json, .github/workflows/ci.yml, and the current origin/main README/domain docs.

Blocking P0/P1 findings:

• P1 merge gate: PR head b3fb3017dd40acbf345167bd203c3000a8867cc1 is not currently mergeable into main. Current origin/main is 7111c3dcb47bbdad882d0cb558256f0b86532baf, and the conflict is in README.md after the main-branch documentation rewrite. This blocks landing even though the code/test behavior of this PR is otherwise sound.

Non-blocking follow-ups:

• The raw bun test command is confusing for reviewers because it bypasses scripts/test.sh and fails on cross-file mock leakage that the package-declared bun run test gate already avoids. CI and package.json use bun run verify:release / bun run test, which passed here.

[andrei-hasna]

Fixed the blocking mergeability issue found in the review.

What changed:

• Merged current origin/main into PR 63a87f71: BUG: attachments — 'domain configure' is metadata-only; does not aut #25 on branch drain/63a87f71-ms62ntmb.
• Resolved the single README.md conflict by preserving the refreshed main-branch docs and keeping the PR's explicit warning that domain configure only stores metadata and deploys no DNS, Cloudflare Workers, or provider routes.
• Commit pushed: ee6693bc20a10dfd9b91e6b492c8d616a518d6a4 (chore: merge main into PR 25, trailer Agent: Augustus).

Verification after the fix:

• git diff --check origin/main...HEAD: exit 0
• staged secrets scan on added lines before commit: exit 0, no high-confidence credential patterns found
• pre-push secrets scan on outgoing added lines: exit 0, no high-confidence credential patterns found
• bun install: exit 0
• bun run typecheck: exit 0
• bun run test: exit 0 (Checks: 54 total, 54 passed, 0 failed)
• bun test src/cli/commands/domain.test.ts: exit 0

GitHub checks are currently queued on the new head; I will merge only if the required checks pass.

[andrei-hasna]

[REVIEW] GO — #25 @ ee6693b — lens: focused verification of mergeability blocker, reviewer Augustus (1 of 1)

Focused re-review result: GO.

The named blocker from the initial review was the README.md merge conflict against current main. That is fixed by ee6693bc20a10dfd9b91e6b492c8d616a518d6a4, and GitHub now reports mergeStateStatus: CLEAN for PR #25.

Post-fix gates and checks:

• bun install: exit 0
• bun run typecheck: exit 0
• bun run test: exit 0 (Checks: 54 total, 54 passed, 0 failed)
• bun test src/cli/commands/domain.test.ts: exit 0
• git diff --check origin/main...HEAD: exit 0
• staged added-line secrets scan before commit: exit 0, no high-confidence credential patterns found
• pre-push outgoing added-line secrets scan: exit 0, no high-confidence credential patterns found
• GitHub check verify: SUCCESS
• GitHub check live-postgres: SUCCESS

Blocking P0/P1 findings: none remaining.

Non-blocking follow-up remains: raw bun test bypasses the repo harness and fails on cross-file mock leakage; the package-declared and CI-used bun run test gate passes.