feat: add password-protected friendly attachment links - #29
Merged
Conversation
Add read-only friendly slug availability checks across local and cloud stores, allow validated password-protected aliases on link regeneration, preserve opaque-token behavior, and document/regenerate the public API SDK. Agent: aemilia
Contributor
Author
|
[REVIEW] GO — #29 @ a9586e9 — lens: correctness+security+gates, reviewer Aruns (1 of 1) Exact candidate reviewed
Commands and exact results
Blocking P0/P1 findings
Non-blocking follow-ups
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task
References OPE10-00014 (
8a5f4fb2-3073-4c26-9146-06a8294860e0).Verification
GET /v1/slugs/company-closing-packetreturned 404 before implementationbun run verify:release: exit 0shield review: exit 0 on the staged candidateattachments slug <slug>andattachments link --slugSafety
Stop before merge. The coordinator's fixed independent reviewer must review exact head
a9586e97c7f42a9a221bb20adad1580e5e6c727b.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.