feat: Align open-banking with @hasna/contracts - #4
Merged
andrei-hasna merged 2 commits intoJul 29, 2026
Conversation
Align open-banking with @hasna/contracts Run the @hasna/contracts conformance check for this repo and fix every violation until it passes — ensure a valid hasna.contract.json, published_artifact_gate satisfied (artifact-scan wired into prepack), storage waiver where applicable, and all required metadata/scripts present. Keep changes minimal and conformant. Open a PR; do not merge. X-Factory-Run: run_6f82f44a69ec X-Factory-Task: d4aabb41-3361-45b7-87da-1c0e11f85d70
The manifest added in this branch was not a hasna.service_contract.v1 document, so `contracts repo-conformance .` failed at manifest_valid and the branch never moved the gate from fail to pass. - Rewrite hasna.contract.json in the real v1 shape: schema, lowercase dashed name, class, contractVersion, kitVersion, description, bins, hosting, and serviceSurfaces for the SDK, CLI, and MCP entrypoints. The invented top-level `waivers` array becomes metadata.conformance.waivedStorageEngines, the documented key. `$schema` points at the kit's own schema file, which resolves after install, instead of a raw.githubusercontent URL that 404s. - Declare metadata.release.artifactScan.script so published_artifact_gate can find the scan, and pin the kit in every script that runs it, as the gate requires for reproducibility. - artifact-scan now packs a tarball and scans it, so the scan runs in packed_artifact mode rather than against the source tree. - contracts:check called a `check` subcommand the kit does not expose and exited 1 every time; it now calls repo-conformance. - CI runs both gates on pull_request, so a regression in the manifest turns the build red instead of passing unnoticed. `contracts repo-conformance .` exits 0 with every check pass or skip.
andrei-hasna
deleted the
factory/d4aabb41-3361-45b7-87da-1c0e11f8-eae1cf82
branch
July 29, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Align open-banking with @hasna/contracts
Run the @hasna/contracts conformance check for this repo and fix every violation until it passes — ensure a valid hasna.contract.json, published_artifact_gate satisfied (artifact-scan wired into prepack), storage waiver where applicable, and all required metadata/scripts present. Keep changes minimal and conformant. Open a PR; do not merge.
Verification
Run
run_6f82f44a69ec· backendcodewith· taskd4aabb41-3361-45b7-87da-1c0e11f85d70🏭 Generated by @hasnaxyz/factory
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.