Skip to content

chore(deps): bump ansi-to-tui from 7.0.0 to 8.0.1 in /codex-rs - #567

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/codex-rs/ansi-to-tui-8.0.1
Open

chore(deps): bump ansi-to-tui from 7.0.0 to 8.0.1 in /codex-rs#567
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/codex-rs/ansi-to-tui-8.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 11, 2026

Copy link
Copy Markdown
Contributor

Bumps ansi-to-tui from 7.0.0 to 8.0.1.

Release notes

Sourced from ansi-to-tui's releases.

v8.0.1

Fixed

  • (parser) normalize CR and CRLF newlines (#80)

Other

  • (deps) bump lru from 0.16.2 to 0.16.3 (#81)
  • add CR/LF characterization tests (#79)
  • Add SGR tests; handle 27 and fix 107 (#78)
  • add cargo workflow alongside Nix (#77)
  • polish Ratatui docs and metadata (#76)
  • update license (#74)

v8.0.0

Fixed

  • Fix failing tests with disabled default features (#63)

Other

  • update ratatui-core to 0.1.0 (#72)
  • enable trusted publishing (#69)
  • set edition to 2024 (#67)
  • unrelease 7.0.1 (#65)
  • (parser) refresh deps and benchmarks (#64)
  • update to ratatui-0.30 pre-release (#60)
  • release v7.0.1 (#59)
  • indicate in README that into_text is fallible (#62)
  • Fix reset for underline/blink/italic/hidden (#57)

v8.0.0-beta.0

Fixed

  • Fix failing tests with disabled default features (#63)

Other

  • set edition to 2024 (#67)
  • unrelease 7.0.1 (#65)
  • (parser) refresh deps and benchmarks (#64)
  • update to ratatui-0.30 pre-release (#60)
  • release v7.0.1 (#59)
  • indicate in README that into_text is fallible (#62)
  • Fix reset for underline/blink/italic/hidden (#57)
Changelog

Sourced from ansi-to-tui's changelog.

8.0.1 - 2026-01-10

Fixed

  • (parser) normalize CR and CRLF newlines (#80)

Other

  • (deps) bump lru from 0.16.2 to 0.16.3 (#81)
  • add CR/LF characterization tests (#79)
  • Add SGR tests; handle 27 and fix 107 (#78)
  • add cargo workflow alongside Nix (#77)
  • polish Ratatui docs and metadata (#76)
  • update license (#74)

8.0.0 - 2025-12-26

Fixed

  • Fix failing tests with disabled default features (#63)

Other

  • update ratatui-core to 0.1.0 (#72)
  • enable trusted publishing (#69)
  • set edition to 2024 (#67)
  • unrelease 7.0.1 (#65)
  • (parser) refresh deps and benchmarks (#64)
  • update to ratatui-0.30 pre-release (#60)
  • release v7.0.1 (#59)
  • indicate in README that into_text is fallible (#62)
  • Fix reset for underline/blink/italic/hidden (#57)
Commits


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Aug 11, 2026
@dependabot
dependabot Bot force-pushed the dependabot/cargo/codex-rs/ansi-to-tui-8.0.1 branch from 7781ced to 0680616 Compare August 12, 2026 05:36
@andrei-hasna

Copy link
Copy Markdown
Contributor

[REVIEW] NO_GO — #567 @ 0680616 — lens: correctness+security+gates, reviewer Hostus (1 of 1)

Exact candidate reviewed

  • Base: origin/main at cffcff2.
  • Head: 0680616.
  • git log --oneline origin/main..HEAD: exit 0.
  • git diff origin/main...HEAD --stat: exit 0; 2 files, 161 insertions, 87 deletions.
  • Full diff read for codex-rs/Cargo.toml and codex-rs/Cargo.lock, plus surrounding source in codex-rs/ansi-escape/src/lib.rs, its manifest/README, MODULE.bazel.lock, the Bazel lock recipes, and upstream ansi-to-tui 7.0.0/8.0.1 manifests, library source, and changelog.

Setup and declared repository gates

  • bun install: exit 0; 521 packages installed. This was setup, not a test gate.
  • Root package.json declares no test script: repo test gate does not exist; pass/fail count 0/0.
  • Root package.json declares no typecheck script: repo typecheck gate does not exist; pass/fail count 0/0.
  • gh pr view 567 --repo hasna/codewith --json statusCheckRollup: exit 0; 41 checks read. Counts at review: 14 SUCCESS, 3 FAILURE, 21 IN_PROGRESS, 3 SKIPPED.

Forge checks read by name

  • FAILURE — Bazel test on ubuntu-24.04 for x86_64-unknown-linux-gnu
  • FAILURE — Build Codewith Linux CLI
  • SUCCESS — cla
  • SUCCESS — Check for spelling errors
  • SUCCESS — Blob size policy
  • SUCCESS — cargo-deny
  • SUCCESS — build-test
  • SUCCESS — Detect changed areas
  • SUCCESS — python-sdk
  • SUCCESS — metadata
  • IN_PROGRESS — Bazel test on ubuntu-24.04 for x86_64-unknown-linux-musl
  • FAILURE — sdks
  • IN_PROGRESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 1/4
  • IN_PROGRESS — Build release x86_64-unknown-linux-gnu
  • SUCCESS — Format / etc
  • IN_PROGRESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 2/4
  • IN_PROGRESS — Build ptrcomp-sandbox x86_64-unknown-linux-gnu
  • IN_PROGRESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 3/4
  • IN_PROGRESS — Build release aarch64-unknown-linux-gnu
  • IN_PROGRESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 4/4
  • IN_PROGRESS — Build ptrcomp-sandbox aarch64-unknown-linux-gnu
  • SUCCESS — Build release x86_64-apple-darwin
  • SUCCESS — Build ptrcomp-sandbox x86_64-apple-darwin
  • SUCCESS — Build release aarch64-apple-darwin
  • SUCCESS — Build ptrcomp-sandbox aarch64-apple-darwin
  • IN_PROGRESS — Build release x86_64-unknown-linux-musl
  • IN_PROGRESS — Build ptrcomp-sandbox x86_64-unknown-linux-musl
  • IN_PROGRESS — Build release aarch64-unknown-linux-musl
  • IN_PROGRESS — Build ptrcomp-sandbox aarch64-unknown-linux-musl
  • IN_PROGRESS — Build ptrcomp-sandbox x86_64-pc-windows-msvc from source
  • SKIPPED — Bazel test on windows-latest for x86_64-pc-windows-gnullvm (native main)
  • SUCCESS — cargo shear
  • IN_PROGRESS — Build ptrcomp-sandbox aarch64-pc-windows-msvc from source
  • IN_PROGRESS — Bazel clippy on ubuntu-24.04 for x86_64-unknown-linux-gnu
  • SKIPPED — Argument comment lint package
  • IN_PROGRESS — Bazel clippy on windows-latest for x86_64-pc-windows-gnullvm
  • IN_PROGRESS — Verify release build on ubuntu-24.04 for x86_64-unknown-linux-gnu
  • IN_PROGRESS — Argument comment lint - Linux
  • IN_PROGRESS — Verify release build on windows-latest for x86_64-pc-windows-gnullvm
  • IN_PROGRESS — Argument comment lint - Windows
  • SKIPPED — [code]smith

Chosen diagnostic lane, not a repo gate

  • Dispatched Blacksmith Testbox run 31567513679 for cd codex-rs && just check-fast -p codex-ansi-escape: dispatch exit 0. The run remained in system-package setup and was cancelled as redundant after the authoritative forge logs became available; the requested command did not execute and therefore has no command exit code. This lane is not used as a blocker.

Blocking P0/P1 findings

  1. P1 — The workspace does not compile after the major dependency bump. ansi-to-tui 8.0.1 returns ratatui_core::text::Text, while codex-ansi-escape still returns ratatui::text::Text from the separately pinned ratatui 0.29 fork. Both Build Codewith Linux CLI and sdks reproduce error[E0308]: mismatched types, expected Text<'static>, found ratatui_core::text::text::Text<'_>, then could not compile codex-ansi-escape; each exits 101. Remedy: retain ansi-to-tui 7.0.0, or migrate the pinned ratatui fork and wrapper/callers to the 0.30/ratatui-core type boundary with focused ANSI-rendering coverage.
  2. P1 — The required Bazel dependency lock was not regenerated. MODULE.bazel.lock still records ansi-to-tui_7.0.0; the Linux Bazel test reports MODULE.bazel.lock is out of date. and exits 1. After settling the compatible dependency migration, run the repository's just bazel-lock-update, include the updated lock, and rerun the applicable Bazel gates.

Security

  • No concrete, currently reachable security P0/P1 finding in the changed dependency declaration or lockfile.

Non-blocking follow-ups

  • The repository declares no root test gate and no root typecheck gate; that is a test-surface finding, not permission to invent a gate.
  • ansi-to-tui 8.0.1 changes CR/CRLF normalization. If the compatible ratatui migration proceeds, add focused integration coverage for that user-visible ANSI parsing behavior.
  • The 248-line change is predominantly mechanical lockfile churn and is below the review-size threshold.

Disposition

  • NO_GO remains live for this exact head. This is real migration work, so no source fix was pushed and no merge was attempted.

Bumps [ansi-to-tui](https://github.com/ratatui/ansi-to-tui) from 7.0.0 to 8.0.1.
- [Release notes](https://github.com/ratatui/ansi-to-tui/releases)
- [Changelog](https://github.com/ratatui/ansi-to-tui/blob/main/CHANGELOG.md)
- [Commits](ratatui/ansi-to-tui@v7.0.0...v8.0.1)

---
updated-dependencies:
- dependency-name: ansi-to-tui
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/cargo/codex-rs/ansi-to-tui-8.0.1 branch from 0680616 to 5feb6f6 Compare August 12, 2026 16:09
@andrei-hasna

Copy link
Copy Markdown
Contributor

[REVIEW] NO_GO — #567 @ 5feb6f6 — lens: correctness+security+gates, reviewer unresolved-account011 (1 of 1)

What I ran

  • git log --oneline origin/main..HEAD — exit 0; 1 commit.
  • git diff origin/main...HEAD --stat — exit 0; 2 files changed, 139 insertions, 65 deletions.
  • Full diff of codex-rs/Cargo.toml and codex-rs/Cargo.lock — exit 0.
  • bun install — exit 0; setup only, not a repository gate; 521 packages installed. It created an untracked bun.lock, which I removed; the candidate worktree is clean.
  • gh pr view 567 --repo hasna/codewith --json statusCheckRollup with a boundary projection limited to check name/status/conclusion — exit 0; 43 checks: 26 SUCCESS, 13 FAILURE, 3 SKIPPED, 1 CANCELLED.
  • PR state/head projection — exit 0; head matches 5feb6f64d59b2bcf60d2b445be3119119b96dd2d, base is main, PR is open and non-draft, merge state is UNSTABLE.
  • GitHub workflow/job/step projections for the failed runs — exit 0 for each query.

Declared gates

  • The root package.json declares no test script. The repository therefore declares no test gate in that manifest.
  • The root package.json declares no typecheck script.
  • I did not invent or run a lane-chosen local test command. The authoritative forge checks are listed below.

Forge checks read

  • Bazel test on ubuntu-24.04 for x86_64-unknown-linux-gnu — FAILURE
  • cargo-deny — FAILURE
  • Build Codewith Linux CLI — FAILURE
  • cla — SUCCESS
  • Check for spelling errors — SUCCESS
  • Blob size policy — SUCCESS
  • build-test — SUCCESS
  • Detect changed areas — SUCCESS
  • python-sdk — SUCCESS
  • metadata — SUCCESS
  • Bazel test on ubuntu-24.04 for x86_64-unknown-linux-musl — FAILURE
  • sdks — FAILURE
  • Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 1/4 — SUCCESS
  • Format / etc — SUCCESS
  • Build release x86_64-unknown-linux-gnu — SUCCESS
  • Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 2/4 — SUCCESS
  • Build ptrcomp-sandbox x86_64-unknown-linux-gnu — SUCCESS
  • Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 3/4 — FAILURE
  • Build release aarch64-unknown-linux-gnu — SUCCESS
  • Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 4/4 — SUCCESS
  • Build ptrcomp-sandbox aarch64-unknown-linux-gnu — SUCCESS
  • Build release x86_64-apple-darwin — SUCCESS
  • Build ptrcomp-sandbox x86_64-apple-darwin — SUCCESS
  • Build release aarch64-apple-darwin — SUCCESS
  • Build ptrcomp-sandbox aarch64-apple-darwin — SUCCESS
  • Build release x86_64-unknown-linux-musl — SUCCESS
  • Build ptrcomp-sandbox x86_64-unknown-linux-musl — SUCCESS
  • Build release aarch64-unknown-linux-musl — SUCCESS
  • Build ptrcomp-sandbox aarch64-unknown-linux-musl — SUCCESS
  • Bazel test on windows-latest for x86_64-pc-windows-gnullvm (native main) — SKIPPED
  • cargo shear — SUCCESS
  • Build ptrcomp-sandbox x86_64-pc-windows-msvc from source — SUCCESS
  • Build ptrcomp-sandbox aarch64-pc-windows-msvc from source — SUCCESS
  • Bazel clippy on ubuntu-24.04 for x86_64-unknown-linux-gnu — FAILURE
  • Argument comment lint package — SKIPPED
  • Bazel clippy on windows-latest for x86_64-pc-windows-gnullvm — FAILURE
  • Verify release build on ubuntu-24.04 for x86_64-unknown-linux-gnu — FAILURE
  • Argument comment lint - Linux — CANCELLED
  • Verify release build on windows-latest for x86_64-pc-windows-gnullvm — FAILURE
  • Argument comment lint - Windows — FAILURE
  • Bazel test on windows-latest for x86_64-pc-windows-gnullvm — FAILURE
  • CI results (required) — FAILURE
  • [code]smith — SKIPPED

What I read

  • Every changed line in codex-rs/Cargo.toml and codex-rs/Cargo.lock.
  • The complete codex-rs/ansi-escape/src/lib.rs wrapper and its Cargo/Bazel manifests and README.
  • The existing ANSI stripping regression in codex-rs/tui/tests/suite/status_indicator.rs.
  • The execution-cell and diff-overlay call paths that consume ansi_escape_line.
  • The repository Bazel lock check in .github/workflows/bazel.yml, justfile, and the failed GitHub job/step results.
  • The upstream ansi-to-tui 8.0.1 API source, which imports ratatui_core::text::Text and returns that type from IntoText::into_text.

Blocking P0/P1 findings

  1. P1 — the dependency major bump breaks the current ANSI conversion build boundary. codex-rs/ansi-escape/src/lib.rs returns ratatui::text::Text, but ansi-to-tui 8.0.1 returns ratatui_core::text::Text. The lockfile shows the existing git-pinned ratatui 0.29.0 and the newly added registry ratatui-core 0.1.2 as separate crate/type lines. The authoritative Cargo SDK/CLI and multiple Bazel build, test, clippy, and release-verification checks fail on this exact head.
  2. P1 — MODULE.bazel.lock was not regenerated for the Rust dependency graph change. The required Check MODULE.bazel.lock is up to date step fails on this exact head, and CI results (required) is FAILURE.

Required remedy

  • Keep the ANSI parser and the repo's Ratatui type graph on one compatible type line, then regenerate and commit MODULE.bazel.lock with the repository's supported update path. Re-run the affected Cargo/Bazel, cargo-deny, SDK/CLI, and required aggregate checks. This is broader than a safe one-line reviewer repair because the repo pins a custom Ratatui revision and the v8 dependency changes the public return type.

Non-blocking follow-ups

  • The root package manifest's absence of both a test script and a typecheck script is recorded above; I did not treat an undeclared local command as a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant