Skip to content

fix: require complete successful deployment attempts - #97

Merged
andrei-hasna merged 1 commit into
mainfrom
fix/contracts-deployment-attempt-completeness
Aug 9, 2026
Merged

fix: require complete successful deployment attempts#97
andrei-hasna merged 1 commit into
mainfrom
fix/contracts-deployment-attempt-completeness

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require a succeeded deployment attempt to include every action in its linked deployment plan
  • preserve partial action ledgers for non-success terminal and in-progress attempts
  • add a two-action regression proving an omitted action fails contract-set validation

Review lineage

Follow-up remediation for the current-head P1 recorded on #96 by reviewer Trebius. PR #96 was already squash-merged before the NO_GO comment was posted, so this separate PR carries the smallest fix on current main.

Verification

  • bun run typecheck — exit 0
  • bun run test before fix — exit 1, 1357 pass, 7 skip, 1 fail; only the new regression failed
  • bun run test after fix — exit 0, 1358 pass, 7 skip, 0 fail
  • staged secrets scan — exit 0, no leaks found
  • exact commit-range secrets scan — exit 0, no leaks found

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

[REVIEW] GO — #97 @ 0a7814b — lens: focused remediation for #96 plan-completeness P1, reviewer Trebius (1 of 1)

Focused re-review scope: the named successful-attempt plan-completeness defect, its regression, and direct deployment-validator regressions only.

  • The validator now rejects a succeeded attempt when its unique action-step count is smaller than the linked plan's unique action set; the existing unknown-action validation still rejects replacements or extras.
  • The regression constructs a fully re-digested two-action plan, approval, successful attempt, provider receipt, deployment receipt, and launch evidence while omitting one attempted action, and now receives the exact fail-closed issue.
  • bun run typecheck — exit 0.
  • bun run test — exit 0; 1358 pass, 7 skip, 0 fail across 1365 tests and 60 files.
  • Staged and exact commit-range secret scans — exit 0; no leaks found.
  • Commit tree matches the tested remediation tree exactly (git diff --quiet da8f180 0a7814b — exit 0).

Blocking P0/P1 findings: none remain in the focused remediation scope.
Non-blocking follow-ups: none.

@andrei-hasna
andrei-hasna merged commit 89c63aa into main Aug 9, 2026
3 checks passed
@andrei-hasna
andrei-hasna deleted the fix/contracts-deployment-attempt-completeness branch August 9, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant