fix(sdk): preserve repeated array query parameters - #98
Merged
Conversation
Agent: Theophrastus
Contributor
Author
Independent adversarial review — GOExact candidate reviewed:
Verdict: GO — zero unresolved in-scope P0/P1 behavior, security, integrity, or compatibility defects. Evidence checked:
Non-blocking P2 follow-up: the generator still does not model non-default OpenAPI query |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLSearchParams.appendsetfor scalar values and omit empty arrays plus null/undefined query valuesFix Once evidence
bun test tests/sdk.test.ts-> rc=1, 2 pass / 1 fail / 14 assertions; received["red,blue,green"]instead of["red", "blue,green"]bun test tests/sdk.test.ts-> rc=0, 3 pass / 0 fail / 18 assertionsbun run verify:release-> rc=0, 1358 pass / 7 skip / 0 fail / 13767 assertions; generated artifacts current, conformance/build/dist smoke/isolated consumer/pack/artifact scan passedorigin/main..HEADgitleaks scans -> rc=0, zero findingsScope and provenance
3a732d10-4f7e-48a9-b68e-ce3d32fe31e3(DUB-00034)Compatibility note
The runtime change applies to every generated client when a query value is an array, matching OpenAPI form-query default repeated-key semantics. No explicit
explode: falseuse was found across currenthasnaorhasnaxyzcode search; explicit non-default query serialization remains unsupported by this generator and is the residual compatibility risk.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.