fix(reply): scope cloud parent resolution - #146
Merged
Conversation
Resolve numeric parents inside the supplied channel or session, fall back to the legacy collection UUID filter when the dedicated route is absent, and cover both compatibility failures end to end. Refs: OPE104-00075 Agent: Theophrastus
Contributor
Author
|
Independent adversarial review: GO at exact head |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/messages?uuid=filter when an older server does not expose/messages/by-uuid/:uuid.replycommand.mementosrow and the dedicated UUID route returns 404.Refs: OPE104-00075
Test plan
bun test src/cli/reply-reference-cloud-compat.e2e.test.ts src/lib/store/api-store.test.ts src/cli/reply-threading.e2e.test.ts src/cli/send-attachments-reply.e2e.test.ts— 62 pass, 0 fail, 248 expect()bun test— 1812 pass, 0 fail, 6395 expect()bun run typecheckbun run buildgit diff --cached --checkgitleaks git --staged --redact --no-banner— no leaks foundgitleaks git --log-opts="origin/main..HEAD" --redact --no-banner— 1 commit scanned, no leaks foundNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.