fix(release): version self-report parity — 0.1.8 + prepublish gate - #26
Merged
Conversation
…blish Release PR #25 bumped package.json to 0.1.7 and left the hand-maintained gatewayVersion constant at 0.1.6, so main AND the published 0.1.7 artifact answer `gateway --version` with 0.1.6. Any consumer verifying installed-version against the registry reads a false mismatch from the shipped artifact. - bump src/version.ts and package.json together to 0.1.8 - tests/version-parity.test.ts: regression asserting gatewayVersion === package.json version — RED on unmodified main (0 pass / 1 fail), green here - prepublishOnly now runs scripts/verify-version-parity.mjs first, so a skewed publish fails with VERSION_PARITY_FAILED (verified two-sided: rc=1 on a skewed manifest, rc=0 on parity) Suite: 260 pass / 1 skip / 0 fail; typecheck clean. Refs todos a403124e-fc9e-412c-92e5-6597fdea005b. Agent: agent-chief-planning
Contributor
Author
|
[REVIEW] GO — #26 @ bb7a7b2 — lens: correctness+security+gates, reviewer Xenon (1 of 1) What I ran:
What I read:
Blocking P0/P1 findings: none. Non-blocking follow-ups: none. Security assessment: no changed authentication, authorization, secret, data-integrity, or external-input path. The release gate fails closed when the version constant is absent or differs from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Release PR #25 bumped package.json only, so main and the published 0.1.7 artifact self-report 0.1.6 from
gateway --version(the hand-maintainedgatewayVersionconstant in src/version.ts was never bumped). This PR:tests/version-parity.test.ts— genuinely RED on unmodified main (0 pass / 1 fail, rc=1), green hereprepublishOnlyonscripts/verify-version-parity.mjs, so a skewed publish fails instead of shipping a lying artifactEvidence
0 pass / 1 fail(0.1.6 vs 0.1.7)1 pass / 0 fail; full suite260 pass / 1 skip / 0 fail;tsc --noEmitcleanVERSION_PARITY_FAILED: src/version.ts gatewayVersion=0.1.8 != package.json version=0.1.99(rc=1) /version parity ok: 0.1.8(rc=0)Rows
a403124e-fc9e-412c-92e5-6597fdea005b(BUG: main and published 0.1.7 self-report 0.1.6)7dd67da6-9ede-483a-ac3f-acd21cecd7f5— closes the installed-version-verify gap of the wave-2capacity-cli-and-affinitylane (hasna-internal/platform#61)After merge: publish 0.1.8,
bun install -g @hasna/gateway, verifygateway --versionreports 0.1.8.Agent: agent-chief-planning
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.