fix: return bounded complete profile reads - #61
Merged
Conversation
Agent: Vitruvius
Agent: Vitruvius
Contributor
Author
|
Remediation cycle 1 is ready for focused re-review at exact head Only the two named P1 blockers and direct regressions changed:
Regression-first evidence: pre-fix Additional gates:
The non-blocking MCP and package-home items were not changed. No merge, publish, install, profile apply, or rollout was performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug and blocked activation
898b3895-1f61-4e77-8c52-be28493f1d4a54ea58f4-f841-4575-a37f-9498ce3b5d2f582337eb-f882-4c6e-9206-4979c290eae7station02Regression-first evidence
Before the implementation,
src/cli/profile-reads.test.tsfailed all three cases: list JSON returned all six profiles despite--limit 2, while show/resolve lacked the required JSON read surface (0 pass,3 fail, exit 1).After the implementation:
39 pass,0 fail, exit 0613 pass,0 fail, exit 0no leaks found, exit 01 commits scanned,no leaks found, exit 0The repository package-manager guard also ran and reported 11 pre-existing untracked home findings in
~/.bunfig.tomland~/.npmrc; it did not inspect or print values and is unrelated to this staged diff.Overlap analysis
PR #59 was already squash-merged as base commit
361c3e94b746609cc9d7ff0fc86bed77c1b1d2ea. This PR keeps its profile-update behavior and changes only new bounded-read hunks plus the necessary test parser adaptation; no active overlap remains.Scope
No merge, publish, install, profile mutation, or rollout is included. The parent coordinator will supply the fixed independent adversarial review against this exact head.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.