fix: redact exec streams before truncation - #86
Merged
Conversation
Agent: agent-ea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged PR #85. The prior fix used a fixed raw-output lookahead before redaction. That is unsafe when an earlier credential is redacted to a shorter marker: the contraction can move a later credential prefix from beyond the raw collection cap into visible bounded output.
This change:
Regression evidence
On the merged PR #85 state (
cd6f02a4421b6d7998efeff050ed75a4347ef920), the new regression tests failed:The failures covered both:
Verification
Focused exact-candidate suite:
TypeScript:
Staged Shield:
Gitleaks:
One full production-equivalent release verification passed before the final test-only additions:
Three exact-final-candidate
bun run verify:releaseretries each hit a different unchanged 5-second test timeout while station01 load was above its 20-core count:MCP HTTP transport > serves multiple concurrent HTTP clients from one processcli command handling > manifest read subcommands accept -j/--json like the rest of the CLIserve > renders dashboard htmlThe first two affected files passed immediately in isolation:
The timeout issue is tracked separately as Todos task
5c7bd9ac-ae55-4b30-b4cc-cbd110eb4053.Exact-head GitHub CI completed successfully on this commit:
That workflow runs install, typecheck, and the complete Bun test suite. It does not run the build and consumer-conformance stages in
verify:release; those stages passed in the production-equivalent full run above, before the final test-only additions.Tracking
48f9610a-0298-4d75-8b72-1718a508a5a8c2714c14e48343d7d8d9a7f023829c34030b2119cd6f02a4421b6d7998efeff050ed75a4347ef920b0e6bf7a6c18ec7bff9693369e854e9264ed39dcThis PR is not authorized for merge, publish, install, or station02 changes in this lane.