test: bound integration test timeout - #88
Conversation
Agent: agent-ea
|
[REVIEW] GO — #88 @ cc2cb5c — lens: correctness+security+gates, reviewer Xenon (1 of 1) Reviewed the exact change from freshly fetched origin/main b07b2c8 through head cc2cb5c. I read the complete diff and surrounding source for .github/workflows/ci.yml, package.json, scripts/verify-release.ts, and test/test-harness.test.ts, plus every repository reference to bun test, bun run test, verify:release, and the new timeout. Commands and results:
Security/correctness trace: this change only routes CI and release verification through the canonical package test script, gives each Bun test a finite 10-second budget, and adds a harness regression test. It changes no runtime input, authorization, secret handling, network exposure, persistent data, mutation, or rollback path. Blocking P0/P1 findings: none. Non-blocking follow-up: test/test-harness.test.ts leaves its two temporary fixture directories under the OS temp directory. This is bounded test-run cleanup hygiene and does not affect the declared gates or shipping behavior. |
Summary
verify:releasethrough that commandRoot cause
The suite relied on Bun's 5000 ms default even though process and network-simulation tests legitimately approach or exceed it under release load. The reported publish gate measured the smart-SSH LAN-preference test at 5331.72 ms; one fixed sequential control in this change measured 5024.84 ms.
A preload-level
setDefaultTimeoutwas tested and rejected because it overrode the narrowerbun test --timeout 100negative control. Keeping the budget in the canonical package command preserves narrower per-test and command-line limits.Verification
5000ms5024.84msbun run typecheck: passedbun run verify:release: passed twice; each run completed 577 tests, build, consumer conformance, and release verificationTask: OPE34-00026
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.