fix: close exact Bun apply integrity gaps - #90
Merged
Conversation
Remove obsolete unapproved target executors, live-revalidate installed state at apply, and resolve SDK probes from the global install root. Agent: Xenon
andrei-hasna
force-pushed
the
task/caa2a6fa-bun-registry-installer
branch
from
August 10, 2026 18:38
fbb5831 to
d463190
Compare
Contributor
Author
|
[REVIEW] GO — #90 @ d463190 — lens: correctness+security+gates, reviewer Xenon (1 of 1) Focused re-review of the three P1 defects named on #89 and their direct regressions. The remediation tree is unchanged from the tested fix commit, and the candidate is rebased onto current main a5e0bf3. Named defects rechecked:
Exact-head gates and controls:
Blocking P0/P1 findings: none. The prior P2 strict-schema compatibility follow-up remains non-blocking and is not relitigated in this focused pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #89 was merged at a5e0bf3 while the latest current-head review was Xenon's attributed NO_GO. The remediation commit was then pushed to the former head branch and is not contained in main.
This follow-up lands only the three named fixes from that review:
Verification:
bun run typecheck— exit 0.bun run test— exit 0; 606 pass, 0 fail, 3250 expect() calls across 66 files.gitleaks git --staged --redact --no-banner .— exit 0; no leaks found.Remediation commit: fbb5831
Original review: #89 (comment)
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.