Skip to content

fix(cli): accept --path for scoped find - #10

Merged
andrei-hasna merged 1 commit into
mainfrom
fix/search-path-option
Aug 9, 2026
Merged

fix(cli): accept --path for scoped find#10
andrei-hasna merged 1 commit into
mainfrom
fix/search-path-option

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Task: OPE44-00004 / 6a617d81-6cc9-4d8a-b771-c8fd105d3234

Summary

  • accept search find <query> --path <indexed-root> as the filesystem-path form of --root
  • scope roots and rootHealth metadata to the selected indexed root
  • preserve non-zero indexed:false output when no index is configured

Verification

  • focused CLI regression: 3 pass, 0 fail, 22 assertions
  • full suite: 282 pass, 0 fail, 775 assertions
  • bun run typecheck
  • bun run build
  • built CLI positive/negative path controls
  • staged and commit-range secret scans: no leaks found

Release metadata is unchanged because this repository has no changelog and current fix PRs are versioned by the separate release integration.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

[REVIEW] GO — #10 @ 1df8f76 — lens: correctness+security+gates, reviewer unresolved-account002 (1 of 1)

What I ran:

  • bun install — exit 0; setup only, 158 packages installed. This is not reported as a test gate.
  • bun run typecheck — exit 0; 0 TypeScript diagnostics emitted.
  • bun run test — exit 0; 282 pass, 0 fail, 775 expect() calls across 26 files.

What I read:

  • Exact candidate: HEAD 1df8f76312b041ac21467f1e67539256344ab7ec against freshly fetched origin/main 551dc3a674be63b614c48215f0d56a94e3a49b8d.
  • Full diff for src/cli/find-path-cli.test.ts, src/cli/local.ts, and src/lib/local/find.ts.
  • Surrounding CLI parsing/error behavior, indexed-root normalization/resolution and health logic, SQL root filtering for plain and regex path/content queries, MCP/REST/benchmark callers, and existing local-index regression tests.

Blocking P0/P1 findings: none. The new path value is resolved only against an existing indexed root, query filters remain parameterized and bind to the resolved root ID, scoped readiness/health metadata follows the requested root, and the no-index path remains a non-zero indexed:false response.

Non-blocking follow-ups: none specific to this diff.

@andrei-hasna
andrei-hasna merged commit 27ab9b3 into main Aug 9, 2026
2 checks passed
@andrei-hasna
andrei-hasna deleted the fix/search-path-option branch August 9, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant