fix: make index status crash-atomic - #7
Merged
Conversation
Agent: Augustus
Contributor
Author
|
[REVIEW] GO — #7 @ 2943399 — lens: correctness+security+gates, reviewer unresolved-account004 (1 of 1) Reviewed exact candidate What I ran:
What I read:
Adversarial result:
Blocking P0/P1 findings: none. Non-blocking follow-ups: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status='indexing'into the same SQLite transaction as file mutations andstatus='ready'Non-vacuous regression
Before the implementation change,
bun test src/lib/local/wedged-index.test.tsexited 1 with 22 passing and 1 failing test: the killed child left raw statusindexingwhere the priorreadystate was expected. Existing stale/dead-owner recovery tests remained green, isolating the missing transaction boundary.Verification
bun test: 267 pass, 0 fail, 698 assertions across 24 files; no skipsbun run typecheck: exit 0git diff --check: exit 0shield review: no security issues in the 3 staged filesTask: 4c551a36-4bee-4a44-854a-bd27142738b6
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Agent: Augustus