Fix todos add --plan persistence verification - #265
Conversation
Verify requested plan_id at both the /v1 acceptance boundary and remote CLI readback so add --plan cannot return success when linkage is dropped. Cover built CLI, API, SDK/OpenAPI, SQLite, and PostgreSQL adapter paths. Task: DUB-00027 Agent: Theophrastus
|
[REVIEW] GO — #265 @ f150ff3 — lens: correctness+isolation+wiring, reviewer codewith-sol-reviewer (1 of 1) P0: None. P1: None. P2: None. P3: None. The change closes both reachable success paths for a dropped plan link. Could not verify: the exact head was not present in the local object store, so I inspected the supplied diff plus exact-head source fetched read-only and did not run the candidate locally. GitHub's |
Summary
plan_idin the/v1/tasksauthoritative create readbackplan_idagain in remote CLI create readbackRoot cause
Task creation already performed POST-then-GET verification, but acceptance compared only the task ID, parent link, and (when requested) creator attribution. A hosted authority could therefore acknowledge
todos add --plan, return a readable task whoseplan_idwas dropped, and the CLI would still exit successfully.Validation
bun test: 3724 pass, 79 skip, 0 fail across 294 files/v1, built CLI, SDK/OpenAPI, SQLite, and PostgreSQL adapter tests: passbun run typecheck: passbun run build: passbun run verify:release: pass (non-authoritative review mode)gitleaks protect --staged --redact --no-banner: no leaks foundSequencing
This branch is based exactly on merged PR #264 main at
ddf38513317c9c66e044b03859c1798fba835313.Keep this PR in draft and do not begin adversarial review until release PR #262 has merged and released its
hasna/todos/mainlock. Then fetch and rebase onto the new protected main, rerun affected gates, and record the new exact base/head/tree before review.Task: DUB-00027
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.