Skip to content

fix(release): bind review receipts to native Codewith lineage - #267

Merged
andrei-hasna merged 1 commit into
mainfrom
fix/todos-release-codewith-reviewer
Aug 10, 2026
Merged

fix(release): bind review receipts to native Codewith lineage#267
andrei-hasna merged 1 commit into
mainfrom
fix/todos-release-codewith-reviewer

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require RELEASE_REVIEWER_AGENT and the signed payload to name the exact native Codewith sub-agent lineage (/root/...) fixed for the release candidate
  • reject legacy Anscombe/Fable attribution, root coordinators, arbitrary agent labels, and malformed lineages even when configuration and payload agree
  • preserve the fixed Ed25519 authority key, exact reviewer equality, publisher distinction, and every existing repository/commit/package/version/tag/workflow/registry/verdict/blocker binding
  • update the issuance procedure so the same Codewith reviewer lineage that performed the review receives the signing key only after its verdict is final

Todos: T-00065 (f2474658-faf8-4f97-b908-68bc80fc980a)

Exact candidate

  • base: 8862c1d9421f03fea1e183ec6aa5c2c9f5b32721
  • head: 09d8f9bec7e4b939b8db0686120bae5df8421be8
  • tree: 322f97c7208eabaa7b820f60ce655e506d11e43c
  • rollback: git revert 09d8f9bec7e4b939b8db0686120bae5df8421be8

Validation

  • RED control before the fix: 12 pass / 1 fail; expected release-agent-review-reviewer-runtime, received no failure for matching Anscombe
  • focused receipt/workflow/public-release tests: 41 pass / 1 skip / 0 fail
  • typecheck: exit 0
  • broader local bun test: exit 0; output contained 1305 pass / 77 skip / 0 fail
  • no-cloud lane: 36 pass / 1 skip / 0 fail
  • production build: exit 0
  • bun run verify:release: exit 0; package/install smoke printed 0.15.22, exact commit/tree matched this PR, and the package-owned extracted-artifact scanner passed twice
  • mandatory staged scan: exit 0
  • commit-range Gitleaks: 1 commits scanned. / no leaks found
  • push hook: exit 0

Artifact-scan distinction: a direct generic Gitleaks scan of the .tgz was vacuous (scanned ~0 bytes) and is not counted. Extracting the tarball made the generic scan cover 19.46 MB and report six pre-existing identifier-only idempotencyKey false positives in unchanged bundled CLI/server/MCP code; git diff against the base for those bundled source lanes returned 0. The package-owned extracted-artifact scanner is the applicable gate and passed twice.

Review stop condition

One independent native Codewith sub-agent reviews this exact head/tree. The PR advances on GO with zero concrete reachable in-scope P0/P1 blockers; P2/P3, pre-existing, optional-hardening, and unrelated findings are non-blocking follow-ups.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@andrei-hasna
andrei-hasna merged commit 66f0e10 into main Aug 10, 2026
3 checks passed
@andrei-hasna
andrei-hasna deleted the fix/todos-release-codewith-reviewer branch August 10, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant