fix: process Helm deps before --add-images discovery#676
Open
aeltai wants to merge 1 commit into
Open
Conversation
Call ProcessDependencies before rendering charts for image discovery so aliased parent value overrides and dependency conditions match helm template. Stop forcing AddImages when recursively adding dependencies. Fixes hauler-dev#675 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessDependenciesbefore--add-imagestemplate rendering so dependency aliases and conditions matchhelm template/ install behavior--add-dependenciesstill resolves original dependency names/pathsAddImages=truewhen recursively adding dependencies (parent discovery already covers the processed tree)Fixes #675
Test plan
suse-observability-agent1.5.10with minimal values (webhook disabled): discovered images matchhelm template(nostackstate/container-tools)httpHeaderInjectorWebhook.enabled=true: discoverssuse-observability/container-tools:...(notstackstate/...defaults)--add-images --add-dependencies: discovers overridden subchart images once; does not attempt un-overridden subchart defaultsTestStoreChart_AddImages*tests pass