Improve benchmarks and update dependencies#7
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR improves benchmark testing methodology and updates project dependencies for the iobuf module, transitioning from blocking backoff patterns to nonblocking mode with skip-on-failure handling in parallel benchmarks.
Changes:
- Updated dependencies to iox v0.3.2 and spin v0.1.4
- Refactored all parallel benchmarks to use nonblocking mode with continue-on-error pattern instead of b.Fatal() or backoff delays
- Fixed SmallBuffer size documentation in translated READMEs (corrected from 1 KiB to 2 KiB)
- Added comprehensive new benchmarks and tests for pool contention scenarios
- Added Makefile for build automation
- Added GitHub Copilot instructions and funding configuration
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated dependency versions for iox (v0.3.0→v0.3.2) and spin (v0.1.3→v0.1.4) |
| go.sum | Updated checksums for new dependency versions |
| benchmark_test.go | Refactored benchmarks to use nonblocking mode, removed unused imports, added extensive new benchmarks |
| bounded_pool_test.go | Added new contention tests and validation tests for pool behavior |
| README.zh-CN.md | Fixed SmallBuffer size from 1 KiB to 2 KiB in Chinese docs |
| README.ja.md | Fixed SmallBuffer size from 1 KiB to 2 KiB in Japanese docs |
| README.fr.md | Fixed SmallBuffer size from 1 KiB to 2 KiB in French docs |
| README.es.md | Fixed SmallBuffer size from 1 KiB to 2 KiB in Spanish docs |
| Makefile | Added build automation targets (fmt, vet, test, bench, clean) |
| .github/instructions/copilot.instructions.md | Added guidelines for Copilot code review |
| .github/FUNDING.yml | Added GitHub Sponsors configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Improve benchmark and add build tooling for the
iobufmodule.Changes
Test plan
make testpassesmake benchcompletes