ci: align runner coverage with current GitHub kernel baseline#15
Merged
Conversation
Signed-off-by: Robin He <git@hybscloud.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to better match the Linux kernel baseline currently provided by GitHub-hosted runners, while still keeping newer io_uring feature coverage visible without blocking merges.
Changes:
- Add workflow-level concurrency cancellation for superseded runs on the same ref.
- Split Linux testing into a required “pre-6.18 baseline” run (via
go test -skip) plus a non-blocking full-suite run. - Expand non-Linux coverage by adding a macOS vet/build job and including darwin/arm64 in cross-build, while also requesting latest Go patch versions via
check-latest.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:33
timeout-minutes: 5is likely too low now that this job runs twogo teststeps, each with-timeout=180s(up to ~6 minutes just for tests, plus vet/build). This can cause CI to be terminated by GitHub Actions before the Go test timeout fires, making failures flaky and hard to diagnose. Consider increasing the job timeout (e.g., 10–15 min) or reducing/splitting the test workload so it fits reliably.
runs-on: ubuntu-latest
timeout-minutes: 5
strategy:
fail-fast: false
matrix:
Signed-off-by: Robin He <git@hybscloud.com>
Signed-off-by: Robin He <git@hybscloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates CI so the required Linux lane matches the current GitHub-hosted
ubuntu-latestkernel baseline while newer io_uring feature tests remain visible in a non-blocking lane.Changes
actions/setup-go.