Added an option to add nonce security to the add and remove#16
Open
eliotfallon213 wants to merge 1 commit into
Open
Added an option to add nonce security to the add and remove#16eliotfallon213 wants to merge 1 commit into
eliotfallon213 wants to merge 1 commit into
Conversation
Contributor
|
Still think this is a good idea. |
msdev20
reviewed
Feb 13, 2021
| if (!wpfp_get_option('dont_load_js_file')) | ||
| wp_enqueue_script( "wp-favorite-posts", WPFP_PATH . "/wpfp.js", array( 'jquery' ) ); | ||
| if (!wpfp_get_option('dont_load_js_file')) | ||
| wp_enqueue_script( "wp-favroite-posts", WPFP_PATH . "/wpfp.js", array( 'jquery' ) ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked on a site that was "pen" tested recently and to cut a long story short - it was pulled up on not using nonces. It was using this plugin so I have altered it to perform a check on it.
Obviously if a site is cached you won't want to be using this option. I'm fully aware this is a minor issue and wanting to use this feature will be an edge case, but I'd written the code so thought I'd better pay it back as it's a great plugin.