Widen --auto's robust_pca auto-upgrade ceiling from N=10 to N=25 - #24
Merged
Merged
Conversation
The original threshold was set from a benchmark on a synthetic 2000x3000x3 (RGB-shaped, P=18M) array, larger than any real calibration frame this camera produces (raw mono FITS, 2048x3056, P=6.26M) -- it overstated the real cost. Direct measurement on real mono frames of the real shape, after 2.2.5's robust_pca native-kernel fusion (which changed what dominates the per-iteration cost), gave: N=10 45s, N=15 89s, N=20 164s, N=25 258s, N=30 377s/~6.3min (fit validated against a direct N=30 measurement, not just extrapolated). Today's N=25 costs less than half of what N=10 cost when 10 was first judged tolerable for a silent --auto default. Widened ROBUST_PCA_AUTO_MAX_FRAMES to 25 on that basis. N=30's ~6.3min sits right at the old N=10 tolerance bar, so left as the next candidate rather than taken now. Updated the stale comments in cli.py and test_master_method_auto.py that referenced the old synthetic-shape benchmark and threshold history. Tests reference the constant dynamically (not hardcoded), so no test changes needed beyond the stale docstring; full suite (1647 tests) passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ROBUST_PCA_AUTO_MAX_FRAMESthreshold (gates when--autosilently upgrades a calibration master's combine method from median to robust_pca) was set from a benchmark on a synthetic 2000x3000x3 array — larger than any real calibration frame this camera produces, so it overstated the real cost.cli.pyand a test docstring that referenced the old synthetic-shape benchmark.Test plan
ruff check .clean🤖 Generated with Claude Code