style: use unquoted :..// atom in ir_gen.ex for Elixir 1.18 formatter#120
Open
style: use unquoted :..// atom in ir_gen.ex for Elixir 1.18 formatter#120
Conversation
The Elixir 1.18 formatter prefers {:..//, ...} over {:"..//", ...}.
CI runs format checks with Elixir 1.18, so this fixes the CI failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI format check fails on master because Elixir 1.18's formatter prefers unquoted
{:..//, ...}over quoted{:"..//", ...}for the step range operator atom.Fix
Replace all 22 occurrences of
:"..//"with:..\/\/inlib/firebird/compiler/ir_gen.ex, and adjust one multi-line pattern to single-line to match the 1.18 formatter output.All 9,427 tests pass locally.