feat: add --email and --ssh-key flags to signup command#171
Closed
AlephNotation wants to merge 2 commits intomainfrom
Closed
feat: add --email and --ssh-key flags to signup command#171AlephNotation wants to merge 2 commits intomainfrom
AlephNotation wants to merge 2 commits intomainfrom
Conversation
- --email: specify email directly instead of reading from git config - --ssh-key: path to SSH public key file instead of auto-detecting - Validates email format (RFC 5322) and SSH key structure (type, base64 data, size) - Tests for SSH key validation: valid keys, missing files, empty, wrong type, too large, private key
Contributor
Author
|
obsoleted by #172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--emailand--ssh-keyflags tovers signupso users and agents can specify credentials explicitly instead of relying on auto-detection.Usage
Validation
net/mail.ParseAddressssh-ed25519,ssh-rsa,ecdsa-sha2-*,sk-*)Tests
internal/auth/shellauth_test.go— 12 test cases for SSH key validation (valid keys, missing files, empty, wrong type, oversized, private key detection)cmd/signup_test.go— flag existence and defaults