Merged
Conversation
…SConfig.build() (#120) The builder methods unconditionally created notification/alert objects, making it impossible to produce data-only FCM messages. Now, when no notification-related fields are provided, the builders omit the notification (Android) or alert (APNS) from the payload. Also changes `AndroidConfig.build()` visibility default from `Visibility.PRIVATE` to None — FCM applies PRIVATE server-side when omitted, so wire behavior is unchanged.
Gera3dartist
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builder methods unconditionally created notification/alert objects, making it impossible to produce data-only FCM messages. Now, when no notification-related fields are provided, the builders omit the notification (Android) or alert (APNS) from the payload.
Also changes
AndroidConfig.build()visibility default fromVisibility.PRIVATEtoNone— FCM appliesPRIVATEserver-side when omitted, so wire behavior is unchanged.