feat(inbox_ai): add Gemini as a selectable reply provider - #98
Merged
Merged
Conversation
Add INBOX_AI_PROVIDER (openai|gemini) so replies can be generated with Gemini instead of OpenAI, keeping OpenAI as the default so existing deployments are unaffected. Both providers share the same prompts and error-handling shape. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcf9c36eed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The Gemini candidate check only rejected a denylist of policy finish reasons (SAFETY, RECITATION, ...), so MAX_TOKENS and other non-success reasons fell through and a truncated/partial reply was returned as if complete. Require finishReason == "STOP" to accept a candidate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INBOX_AI_PROVIDER(openaidefault, orgemini) so the inbox AI reply extension can generate replies with either OpenAI or Gemini, keeping OpenAI as the default so existing deployments are unaffected.Test plan
pytest apps/inbox_ai/tests— 35/35 pass, including new Gemini provider coverage (ran with local Postgres viadocker compose up -d postgres)ruff check/ruff format --check apps/inbox_aiINBOX_AI_PROVIDER=geminiand confirm output quality/formatting matches the OpenAI path🤖 Generated with Claude Code