Fix compile errors in Genvex ESPHome 2026.1#52
Open
Jogge wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
I'm currently running ESPHome 2025.12.0 with all my patches (#52, #50, #49 & #48), from this repo and branch: https://github.com/Jogge/esphome_components/tree/patches I haven't seen any problems. |
…Ref return type - Adapted to ESPHome API change: get_custom_fan_mode() now returns StringRef instead of const char* - Ensured compatibility with ESPHome 2026.1 and future releases
- Use StringRef::empty() and .c_str() instead of pointer/optional logic - Resolves compile error with new ESPHome API
Contributor
Author
|
I have updated the code, and fixed compile error in ESPHome 2026.1. Again, I'm running all my patches from this repo/branch: https://github.com/Jogge/esphome_components/tree/patches |
Jogge
changed the title
Owner
|
@Jogge In the future, your are very welcome to contribute your fixes and improvement to the develop branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #51.
Since I don’t know C++, I relied heavily on GitHub Copilot for the implementation.
I would really appreciate a detailed review to confirm that the solution is implemented correctly.
Currently I'm running this code (and other patches, #48, #49, #50) from here: https://github.com/Jogge/esphome_components/tree/patches