Bug fixes: JIF page, propPermutation length, Movement curve scan#28
Open
wikkyrose wants to merge 4 commits into
Open
Bug fixes: JIF page, propPermutation length, Movement curve scan#28wikkyrose wants to merge 4 commits into
wikkyrose wants to merge 4 commits into
Conversation
localStorage.getItem('jif') returns null when the key is unset — first visit,
incognito, or after clearing site data. The value was assigned unconditionally to
jifString, so Jif.complete(null) threw "Cannot read properties of null (reading
'meta')" and the page froze with no visible error. Only override the default when a
non-empty value is actually stored. Also drops the no-op second argument to getItem.
Co-authored-by: Claude (Anthropic) <noreply@anthropic.com>
Parse errors and warnings couldn't be selected/copied, which makes it awkward to quote a message when filing a bug or asking for help. Re-enable text selection on the .error and .warnings blocks. Co-authored-by: Claude (Anthropic) <noreply@anthropic.com>
_completeRepetition() checked rep.propPermutation.length against jif.limbs.length, but a propPermutation indexes props — so any pattern where the prop count differs from the limb count (nearly all of them) had a valid propPermutation wrongly reset to identity, with a spurious "invalid size of repetition.propPermutation" warning. Compare against jif.props.length. (limbPermutation just above already, correctly, checks jif.limbs.length.) Co-authored-by: Claude (Anthropic) <noreply@anthropic.com>
getCurveAndFraction() reassigned this.lastIndex on every loop iteration, so the search-start hint grew while scanning and the modular probe index `(lastIndex + i) % nCurves` skipped curves — from lastIndex 0 with 6 curves it visited 0,1,3,0,4,3 and never 2 or 5. The period-wrapping curve could be one of the skipped indices, so the affected prop/hand froze for that span and then snapped to the next curve. Advance lastIndex only when a curve actually matches. Co-authored-by: Claude (Anthropic) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small, independent fixes (each its own commit, based on main):
Your test suite passes (35/35). Generated with Claude/Codex assistance; commits carry Co-authored-by: trailers.