-
Notifications
You must be signed in to change notification settings - Fork 11
Update planetEffects.json #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding new planeteffects to json
Co-authored-by: Lucas Gracioso <34951068+lbgracioso@users.noreply.github.com>
dealloc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
May I recommend adding this too: |
|
|
@dealloc I had a commit ready for this yesterday, It's added now. |
|
@dealloc @lbgracioso just changed "World" to planet. |
|
lgtm now @CrosswaveOmega just a tip for you, check ConventionalCommits. |
dealloc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, lgtm
|
updating the Pull Request for the new Incineration Corps Galactic Effect that was just added. |
Adding the newly revealed PlanetEffects to the planetEffects.json file.
Included:
1: Fractured Planet (Effect 1241,)
2: Operational Support (Effect 1238, applied by the DSS as a passive)
3: Verge of Destruction (Effect 1240, applied to planets threatened by the moving Meridia)
4: Moving Singularity (Effect 1242, applied to Meridia now. It adds a purple line connecting it with Super Earth)