Skip to content

Conversation

@CrosswaveOmega
Copy link
Contributor

Adding the newly revealed PlanetEffects to the planetEffects.json file.

Included:
1: Fractured Planet (Effect 1241,)
2: Operational Support (Effect 1238, applied by the DSS as a passive)
3: Verge of Destruction (Effect 1240, applied to planets threatened by the moving Meridia)
4: Moving Singularity (Effect 1242, applied to Meridia now. It adds a purple line connecting it with Super Earth)

Adding new planeteffects to json
Co-authored-by: Lucas Gracioso <34951068+lbgracioso@users.noreply.github.com>
dealloc
dealloc previously approved these changes Feb 15, 2025
Copy link
Member

@dealloc dealloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Stonemercy
Copy link
Collaborator

May I recommend adding this too:

"1245": {
		"galacticEffectId": 1245,
		"name": "PREDATOR STRAIN",
		"description": "A Gloom-enhanced strain of Terminids has been reported on this planet. SEAF patrols have been lured into ambushes, and picked off by unseen assailants. Every ounce of a Helldiver's superior senses will be required to hunt down this dangerous threat."
	}

@dealloc
Copy link
Member

dealloc commented Feb 16, 2025

May I recommend adding this too:

"1245": {
		"galacticEffectId": 1245,
		"name": "PREDATOR STRAIN",
		"description": "A Gloom-enhanced strain of Terminids has been reported on this planet. SEAF patrols have been lured into ambushes, and picked off by unseen assailants. Every ounce of a Helldiver's superior senses will be required to hunt down this dangerous threat."
	}

CC @CrosswaveOmega

@CrosswaveOmega
Copy link
Contributor Author

@dealloc I had a commit ready for this yesterday, It's added now.

@CrosswaveOmega
Copy link
Contributor Author

@dealloc @lbgracioso just changed "World" to planet.

@lbgracioso
Copy link
Contributor

lgtm now

@CrosswaveOmega just a tip for you, check ConventionalCommits.
Using descriptive commit messages makes it easier to track changes and understand what the commit does.

dealloc
dealloc previously approved these changes Feb 16, 2025
Copy link
Member

@dealloc dealloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, lgtm

@CrosswaveOmega
Copy link
Contributor Author

updating the Pull Request for the new Incineration Corps Galactic Effect that was just added.

@dealloc dealloc merged commit 05f5130 into helldivers-2:master Apr 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants