You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed warranty offer validation to ensure accurate checking during order processing. Warranty offers will now be correctly identified and displayed in quotes.
A method parameter change was made to the isWarrantyInQuote() function call in the warranty-offers.phtml template file. Previously, the method accepted an item SKU string via $_item->getSku(). The call has been updated to pass an item ID as an integer via (int)$_item->getId() instead. Correspondingly, the isWarrantyInQuote() method signature was modified to expect an item ID integer parameter rather than a SKU string. The surrounding control flow and logic remain unchanged.
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 3a02011 and 8f2f501.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on a corresponding one in module-warranty helloextend/magento-extension#426
Summary by CodeRabbit