MONGO_CLIENT flexible setting#5
Open
litwisha wants to merge 13 commits into
Open
Conversation
…ify README.rst. Change requirements in setup.py for django version >=1.6
…instance checker: from `str` to `six.string_types` for python 2
…ted path string to db instance
… settings: `MONGO_CLIENT` or `MONGO_DB`
hellysmile
reviewed
Dec 27, 2016
| @@ -1,9 +1,17 @@ | |||
| import six | |||
…s Database or MongoClient instance, and as dotted path string to the instaces
hellysmile
reviewed
Dec 28, 2016
| Patches and Suggestions | ||
| ``````````````````````` | ||
|
|
||
| - Andrew Lytvyn (``litwisha``) No newline at end of file |
hellysmile
reviewed
Dec 28, 2016
| import six | ||
| from django.conf import settings | ||
| from django.core.exceptions import ImproperlyConfigured | ||
| from django.utils import six |
Owner
There was a problem hiding this comment.
try ImportError -> import six
Contributor
Author
There was a problem hiding this comment.
I checked out all django versions starting from 1.6:
they all have django.utils.six module
Owner
There was a problem hiding this comment.
ok, then set to setup.py >=1.6,<2, there will be no six at django 2
Owner
|
FIx tox.ini/.travis.yml to use django 1.6-1.10, there right now 1.4-1.6 |
Owner
|
Almost one year after, @litwisha are You still interested to make it live? as well I was told that @FedirAlifirenko found bugs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functionality to process
MONGO_CLIENTsetting as dotted path string to connection with database name.