upgrade to version 4.2.3, add authorization, and distinct-vals function#7
Open
dfbernal wants to merge 2 commits intohelpshift:masterfrom
Open
upgrade to version 4.2.3, add authorization, and distinct-vals function#7dfbernal wants to merge 2 commits intohelpshift:masterfrom
dfbernal wants to merge 2 commits intohelpshift:masterfrom
Conversation
ghoseb
reviewed
Aug 1, 2022
project.clj
Outdated
| @@ -1,11 +1,11 @@ | |||
| (defproject helpshift/mongrove "0.2.0" | |||
| (defproject com.github.dfbernal/mongrove "0.2.1" | |||
kapilreddy
reviewed
Sep 26, 2022
| (.writeConcern (get write-concern-map write-concern)) | ||
| (.readPreference (get read-preference-map read-preference)) | ||
| (.retryWrites retry-writes) | ||
| (.credential credential) |
There was a problem hiding this comment.
The credential needs to be conditionally handled. Initialization without a username and password is failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.