Skip to content

Enforce SSL policy errors in custom certificate validation callback #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Enforce SSL policy errors in custom certificate validation callback #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ac9968
Initial plan
Copilot Mar 14, 2026
23a8a98
Fix SSL policy error handling in DockerMessageHandler
Copilot Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/RemoteContainers.Aspire/Docker/DockerMessageHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
// limitations under the License.
// </copyright>

using System.Net.Security;
using System.Security.Cryptography.X509Certificates;

namespace Hj.RemoteContainers.Aspire.Docker;
Expand All @@ -34,9 +35,9 @@ public HttpMessageHandler Init()
if (_dockerCertificate.TryGetCertificate(out _caCert, out _clientCert))
{
ClientCertificates.Add(_clientCert);
ServerCertificateCustomValidationCallback = (_, serverCert, chain, _) =>
ServerCertificateCustomValidationCallback = (_, serverCert, chain, sslPolicyErrors) =>
{
if (serverCert is null || chain is null)
if (serverCert is null || chain is null || (sslPolicyErrors & ~SslPolicyErrors.RemoteCertificateChainErrors) != SslPolicyErrors.None)
{
return false;
Comment thread
henrikhimself marked this conversation as resolved.
}
Expand Down
Loading