Skip to content

Fix: transient HttpRequestException resets stabilization state in DockerApiClient #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix: transient HttpRequestException resets stabilization state in DockerApiClient #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0592ca
Initial plan
Copilot Mar 14, 2026
44065f6
Fix: preserve stabilization state across transient HttpRequestExcepti…
Copilot Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/RemoteContainers.Aspire/Docker/DockerApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,10 @@ public DockerApiClient(ILogger<DockerApiClient> logger, HttpClient httpClient, A
_logger.LogError(ex, "Docker API request failed for {ResourceName}; retrying…", resourceName);
}

lastSeenId = null;
isFirstPoll = false;
// Do not reset lastSeenId or isFirstPoll — a transient error gives no information about the
// container state, so the existing stabilization state must be preserved. Resetting would
// set lastSeenId to null, causing the next successful find to be accepted immediately via the
// "appeared after an empty poll" path, which defeats the two-poll confirmation.
}

await Task.Delay(pollInterval, cancellationToken);
Expand Down