Develop#35
Merged
Merged
Conversation
Owner
henrikhimself
commented
Jan 18, 2026
henrikhimself
commented
- Bump to beta5.
- Adds new documentation, including a detailed AGENTS.md covering architecture, Aspire integration, and testing practices.
- Updates Aspire example projects to Aspire 13.1.0, targets .NET 10.0, and improves HTTPS configuration examples.
- Adds .aspire/settings.json for Aspire app host configuration.
- Enhances testing setup with a new .runsettings file, dotnet-tools.json, and integration of the reportgenerator tool.
- Adds Update-TestCoverage.ps1 and new VS Code tasks for running tests and viewing coverage reports.
- Modernizes build and dependency management with Directory.Packages.props and updated analyzer configuration.
- Refreshes CI/CD workflows to use the latest GitHub Actions and .NET 10.0.
- Improves developer experience with VS Code extension recommendations and an Aspire‑ready launch.json.
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…evelop/github/codeql-action-4 Bump github/codeql-action from 3 to 4
…evelop/actions/checkout-6 Bump actions/checkout from 5 to 6
…ithub workflows. Add test coverage report.
… for macOS and .NET 8. Add logging enhancements and update test report creation.
…ing to user home. Remove optional port in WithReverseProxyReference(...). Add Agents instructions file. Update Aspire to 13 and add settings for cli.
…te to Aspire 13.1.0.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ReverseProxy library to beta5 with substantial improvements across build infrastructure, .NET version support, certificate management, and Aspire integration.
Changes:
- Upgrades to .NET 10.0 (from 9.0) and Aspire 13.1.0
- Adds platform-specific certificate handling for macOS .NET 8 to work around keychain limitations
- Introduces route/cluster overwrite functionality with new
allowOverwriteparameter - Modernizes build system with centralized package management and enhanced test coverage tooling
Reviewed changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updates .NET SDK to 10.0.0 |
| Directory.Packages.props | New centralized package version management |
| Directory.Build.props | Simplifies analyzer configuration, removes SonarAnalyzer |
| src/ReverseProxy/ReverseProxy.csproj | Bumps version to beta5, targets net10.0, adds conditional Pkcs dependency |
| src/ReverseProxy/ReverseProxyApp.cs | Adds allowOverwrite parameter to route/cluster methods, fixes "cluser" typo |
| src/ReverseProxy/ReverseProxyApi.cs | Passes allowOverwrite flag from DTOs to app methods |
| src/ReverseProxy/ReverseProxy/Models/*.cs | Adds AllowOverwrite property to input DTOs |
| src/ReverseProxy/ReverseProxy/LoggerMiddleware.cs | Adds log level guards and improves blackhole message |
| src/ReverseProxy/Certificate/*.cs | Refactors for extensibility with ICertificateCreator and ICaLoader interfaces |
| src/ReverseProxy/Certificate/Strategy/MacOS*.cs | New platform-specific implementations for macOS .NET 8 |
| src/ReverseProxy/Certificate/Strategy/Default*.cs | New default implementations for certificate operations |
| src/ReverseProxy/Certificate/CertificateConfig.cs | Adds REVERSEPROXY_HOME token expansion and CaName support |
| src/ReverseProxy/ReverseProxyExtensions.cs | Registers platform-specific certificate strategies |
| src/ReverseProxy.Aspire/*.csproj | Updates to Aspire SDK 13.1.0, targets net10.0 |
| src/ReverseProxy.Aspire/ResourceBuilderExtensions.cs | Improves port handling by reading from endpoint annotations |
| examples/Aspire.AppHost/Program.cs | Enhanced documentation of HTTPS configuration options |
| examples/Aspire.AppHost/*.csproj | Modernizes to use Aspire.AppHost.Sdk directly |
| examples/*/appsettings.json | Uses REVERSEPROXY_HOME token instead of hardcoded paths |
| test//.csproj | Adds explicit project references, targets net10.0, improves configuration |
| test/Directory.Build.props | Removed (project references moved to individual test projects) |
| test/ReverseProxy.UnitTest/ReverseProxy/ReverseProxyAppTests.cs | Adds comprehensive tests for allowOverwrite functionality |
| test/ReverseProxy.UnitTest/Certificate/*.cs | Adds tests for token expansion and platform-specific logic |
| .runsettings | New test configuration with code coverage settings |
| .config/dotnet-tools.json | Adds reportgenerator tool for coverage reports |
| scripts/Update-TestCoverage.ps1 | New PowerShell script for generating coverage reports |
| Update-TestCoverage.ps1 | Convenience wrapper for test coverage script |
| .vscode/* | Adds Aspire launch config, tasks for testing, extension recommendations |
| .aspire/settings.json | Configures Aspire app host path |
| .github/workflows/*.yml | Updates to checkout@v6, codeql@v4, .NET 10.0 |
| AGENTS.md | Comprehensive documentation for AI assistants covering architecture and workflows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.