Skip to content

Develop#36

Merged
henrikhimself merged 3 commits into
mainfrom
develop
Jan 19, 2026
Merged

Develop#36
henrikhimself merged 3 commits into
mainfrom
develop

Conversation

@henrikhimself
Copy link
Copy Markdown
Owner

  • Improve REVERSEPROXY_HOME.
  • Added test collection for environment‑variable tests
  • Fix missing Aspire.Hosting reference in Aspire extension project.

Copilot AI review requested due to automatic review settings January 19, 2026 07:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the REVERSEPROXY_HOME environment variable handling to require explicit configuration (throwing an exception instead of falling back to the user home directory), adds test infrastructure for environment variable tests, and fixes missing Aspire.Hosting package references.

Changes:

  • Modified REVERSEPROXY_HOME handling to throw an exception when the environment variable is not set, instead of falling back to the user home directory
  • Added "EnvironmentVariable" test collection attribute to CertificateConfigTests to prevent parallel test execution when manipulating environment variables
  • Fixed Aspire extension project by changing SDK from Aspire.AppHost.Sdk to Microsoft.NET.Sdk and adding explicit Aspire.Hosting package reference

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ReverseProxy/Certificate/CertificateConfig.cs Changed REVERSEPROXY_HOME token expansion to throw exception instead of falling back to user home directory
test/ReverseProxy.UnitTest/Certificate/CertificateConfigTests.cs Updated tests to reflect new behavior, added Collection attribute, and improved test cleanup
src/ReverseProxy/ReverseProxy.csproj Version bump from beta5 to beta6
src/ReverseProxy.Aspire/ReverseProxy.Aspire.csproj Changed SDK to Microsoft.NET.Sdk, added Aspire.Hosting package reference, and version bump
src/ReverseProxy.Aspire/ResourceBuilderExtensions.cs Added required using statements for Aspire namespaces
examples/Aspire.Website/Views/Home/Index.cshtml Simplified hosts file mapping instructions
Directory.Packages.props Added Aspire.Hosting version and reordered package entries alphabetically

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


namespace Hj.ReverseProxy.UnitTest.Certificate;

[Collection("EnvironmentVariable")]
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Collection attribute references "EnvironmentVariable" but there is no corresponding CollectionDefinition class defined in the test project. In xUnit, when using the Collection attribute, you need to define a collection definition class with the matching name. Without the definition, this attribute has no effect and tests may run in parallel, potentially causing race conditions when manipulating environment variables.

Copilot uses AI. Check for mistakes.
Comment thread examples/Aspire.Website/Views/Home/Index.cshtml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@henrikhimself henrikhimself merged commit 096134e into main Jan 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants