fix: unbreak main CI after the rust 1.98 toolchain bump - #100
Merged
Merged
Conversation
rustc 1.98 emits -Wl,--fix-cortex-a53-843419 for aarch64 targets (rust-lang/rust#155453). zig's linker rejects the flag, so every arm64 image build has failed since the toolchain bump in #95. cargo-zigbuild 0.23.0 filters the argument out before invoking zig. 0.23.0 keeps the version-branching support for zig 0.14, so ZIG_VERSION stays pinned where it is.
chacha20 0.10.0 and 0.10.1 were yanked upstream after #95 was checked, turning the deny job red on main. The unyanked 0.10.2 was published 2026-08-27 and is still inside the 7-day publish cooldown, so pull it in from 2026-09-03 and drop this exception then.
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 91.20% 91.20%
=======================================
Files 31 31
Lines 4468 4468
=======================================
Hits 4075 4075
Misses 393 393 🚀 New features to boost your workflow:
|
henry40408
added a commit
that referenced
this pull request
Sep 3, 2026
* chore(deps): pull in chacha20 0.10.2 and drop the deny.toml exception chacha20 0.10.0 and 0.10.1 were yanked upstream; #100 parked a temporary `[advisories] ignore` entry because the unyanked 0.10.2 (published 2026-08-27) was still inside the 7-day publish cooldown. That cooldown has cleared, so take the real fix and remove the exception. - `cargo update -p chacha20` (0.10.0 -> 0.10.2) - Drop the `chacha20@0.10.0` ignore entry and revert the `ignore` doc comment now that the list is empty again Closes #101 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(deps): update event-listener to 5.4.2 for RUSTSEC-2026-0221 RUSTSEC-2026-0221 landed after #101 was filed and turns the deny job red independently of the chacha20 yank: event-listener <=5.4.1 unconditionally implements `Send`/`Sync` for `StackSlot<'_, T>`, letting a `!Send` tag set via `Event::with_tag` cross a thread boundary. We reach it only transitively through sqlx-core and never call `Event::with_tag`, but the advisory is a hard `cargo deny` failure either way. 5.4.2 was published 2026-07-27, well clear of the 7-day cooldown. It also drops the concurrent-queue dependency. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both jobs on
mainwent red after #95 merged. This fixes each one.image(Docker) — regression from #95rustc 1.98 emits
-Wl,--fix-cortex-a53-843419for aarch64 targets (rust-lang/rust#155453). zig's linker rejects it, so the arm64 leg fails outright:cargo-zigbuild 0.23.0 filters that argument out before invoking zig (
src/zig.rs, citing the same rustc PR). It is the oldest release with the fix and was published 2026-06-18, so it clears the 7-day publish cooldown — 0.23.2 and 0.23.3 do not. 0.23.0 still branches on the zig version for 0.14, soZIG_VERSIONstays pinned.deny— unrelated, time-triggeredchacha200.10.0 and 0.10.1 were yanked upstream after #95's checks ran, which is why that PR was green andmainis not. It is reached only transitively viarand->sqlx-postgres, and a yank is not a security advisory.The unyanked 0.10.2 was published 2026-08-27 and is still inside the 7-day cooldown, so this adds a temporary
[advisories] ignoreentry instead. #101 tracks pulling in 0.10.2 and dropping the exception from 2026-09-03.Verification
denypasses on this PR, which confirms theignoreentry is accepted by the cargo-deny version CI actually installs (0.20.2).The Docker fix is not covered by this PR's checks —
docker.ymltriggers onpushtomainand onrelease, not onpull_request. It was instead verified by building both images locally from this branch (docker buildx build --platform linux/arm64andlinux/amd64), reproducing the same cross-compile path the workflow uses:No test accompanies this change: a Docker build-arg pin and a cargo-deny config exception are not reachable by
cargo nextest— they are covered by theimageanddenyCI jobs respectively.🤖 Generated with Claude Code