fix(docker): unbreak the arm64 image build, and ignore the yanked chacha20 - #161
Merged
Conversation
Rust 1.98 makes rustc pass `-Wl,--fix-cortex-a53-843419` on aarch64-unknown-linux-musl (rust-lang/rust#155453). zig's linker rejects it, so every arm64 image build since #156 fails with `unsupported linker arg: --fix-cortex-a53-843419`. cargo-zigbuild filters that arg from 0.23.0 onward (rust-cross/cargo-zigbuild#452); the pinned 0.22.3 predates the fix. ci.yml never cross-compiles, so nothing outside docker.yml sees this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 28 28
Lines 13132 13132
=======================================
Hits 12648 12648
Misses 484 484 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 tasks
…e hold chacha20 0.10.1 was yanked upstream, so `cargo deny check` fails on every branch. It is not a security advisory — the crate's only RUSTSEC entry is RUSTSEC-2019-0029 against 0.1.x — and it reaches us transitively via rand. 0.10.0 is yanked too, leaving 0.10.2 (published 2026-08-27) as the only non-yanked stable release, which is inside the 7-day hold on fresh releases. Ignore the yank until 2026-09-03; #162 tracks removing it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
henry40408
added a commit
that referenced
this pull request
Sep 3, 2026
) chacha20 0.10.0 and 0.10.1 are both yanked upstream (a yank, not an advisory). 0.10.2 was published 2026-08-27 and has now cleared the 7-day hold on fresh releases, so take it and remove the stop-gap ignore that #161 added to deny.toml. The crate is transitive only, via rand 0.10.2 under sqlx-postgres and axum-test. The e2e workspace keeps its own lockfile and pinned the same yanked version, so bump it too — cargo-deny only scans the root, but there is no reason to leave the second lock on a yanked release. Closes #162 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated breakages, both of which make
mainred right now.1. arm64 image build (
Dockerfile)Broken since #156 landed Rust 1.98. rustc now passes
-Wl,--fix-cortex-a53-843419foraarch64-unknown-linux-musl(rust-lang/rust#155453) and zig's linker rejects it:
cargo-zigbuild filters that arg from 0.23.0 onward
(rust-cross/cargo-zigbuild#452, fixing rust-cross/cargo-zigbuild#451); the
Dockerfile pinned 0.22.3, which predates it —
src/zig.rs:541atv0.23.0carries the filter,
v0.22.3does not.ZIG_VERSIONstays at 0.14.1 — 0.23.0 still supports it, and the libc++-19bindgen caveat the existing comment names only applies to zig 0.15+.
2. yanked chacha20 (
deny.toml)cargo deny checkfails on every branch witherror[yanked]: detected yanked crate (try 'cargo update -p chacha20').chacha20 0.10.1 was yanked upstream; it is not an advisory and it reaches us
transitively via rand. 0.10.0 is yanked too, so 0.10.2 (published 2026-08-27)
is the only non-yanked stable release — inside the 7-day hold on fresh
releases. Ignored until it clears on 2026-09-03; #162 tracks the removal.
Verification
The Dockerfile change is not reachable from the test harness:
ci.ymlnevercross-compiles, and
docker.ymlonly runs on a push tomainor a tag, so thearm64 build is first exercised after merge. The deny.toml change is covered by
the
cargo-denyjob on this PR.Failing runs for reference:
🤖 Generated with Claude Code