fix(docker): unbreak the arm64 image build under Rust 1.98 - #521
Merged
Merged
Conversation
Rust 1.98 passes `-Wl,--fix-cortex-a53-843419` as a pre-link arg for aarch64-unknown-linux-musl (rust-lang/rust#155453). zig's linker rejects it, so the arm64 leg of the image has failed to link since the toolchain bump in #510: error: unsupported linker arg: --fix-cortex-a53-843419 error: could not compile `rdrs` (bin "rdrs") cargo-zigbuild filters the arg out as of rust-cross/cargo-zigbuild#452, first released in 0.23.0, so ZIGBUILD_VERSION moves 0.22.3 -> 0.23.0. 0.23.1 through 0.23.3 are all inside the seven-day dependency cooldown; 0.23.0 (published 2026-06-16) is the oldest release carrying the fix. ZIG_VERSION stays at 0.14.1 — 0.23.0 still supports it, and the libc++-19 bindgen caveat in the existing comment only applies to zig 0.15+.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 87 87
Lines 25896 25896
=======================================
Hits 24218 24218
Misses 1678 1678 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Dockerworkflow has been failing onmainsince #510 bumped the toolchain to Rust 1.98. Only the arm64 leg is affected; amd64 builds fine.Cause
Rust 1.98 passes
-Wl,--fix-cortex-a53-843419as a pre-link arg foraarch64-unknown-linux-musl(rust-lang/rust#155453). zig's linker does not accept it:Failing run on
main: https://github.com/henry40408/rdrs/actions/runs/33187487621cargo-zigbuild filters that arg out as of rust-cross/cargo-zigbuild#452, first released in 0.23.0. The Dockerfile pinned 0.22.3, which predates the fix.
Change
ZIGBUILD_VERSION0.22.3 → 0.23.0. 0.23.1 through 0.23.3 all landed within the last seven days and are inside this repo's dependency cooldown; 0.23.0 (published 2026-06-16) is the oldest release carrying the fix, and is what noadd, pingward and liftlog already pin.ZIG_VERSIONstays at 0.14.1 — 0.23.0 still supports it, and the libc++-19 bindgen caveat in the existing comment only applies to zig 0.15+.Verification
docker.ymlonly fires on pushes tomainand on tags, so this PR's own checks do not exercise the cross-compile. Verified locally instead:The build emits one benign warning from zig —
linker stderr: ignoring deprecated linker optimization setting '1'— which does not fail the build.No Rust test accompanies this change: it is a single build-argument edit in the
Dockerfile, unreachable from the project's test harness and exercised only by the Docker workflow.🤖 Generated with Claude Code